Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(search): update landing page to encompass talking points & registration #1299

Merged
merged 2 commits into from
Aug 5, 2024

Conversation

IanKrieger
Copy link
Member

Resolves #1296


Screenshare.-.2024-08-02.3_08_03.PM.mp4

@IanKrieger IanKrieger requested a review from a team as a code owner August 2, 2024 19:09
Copy link

github-actions bot commented Aug 2, 2024

[puLL-Merge] - brave/ads-ui@1299

Description

This PR updates the Search landing page and registration process for Brave Search Ads. It introduces new content, layout changes, and a video demonstration of setting up a campaign. The changes aim to improve user experience and provide more information about Brave Search Ads.

Changes

Changes

  1. src/search/SearchLandingPage.tsx:

    • Completely redesigned the layout and content of the Search landing page.
    • Added a new video component showcasing how to set up a Brave Search Ads campaign.
    • Updated text content and messaging to focus on the benefits of Brave Search Ads.
    • Removed the image carousel and replaced it with more structured content sections.
  2. src/search/SearchTalkingPoints.tsx:

    • Updated the talking points with new titles and descriptions.
    • Adjusted the layout and styling of the talking points section.
  3. src/auth/registration/SearchRegister.tsx:

    • Modified the registration form layout and styling.
    • Updated the form submission button text.
  4. src/auth/registration/Register.tsx:

    • Removed the SearchRegister route and added a redirect from "/register/search" to "/search".
  5. src/auth/registration/SearchForm.tsx:

    • Adjusted the width of the form container.
  6. src/basic-attention-token/PrivacyPolicy.tsx:

    • Added a conditional variant for the typography based on whether it's used in the search context.
  7. src/locales/*.po:

    • Updated various translation strings to reflect the new content and messaging.
  8. Added a new video file: src/assets/videos/setting_up_brave_search_ads.mp4

Possible Issues

  1. The removal of the SearchRegister route in Register.tsx might affect existing links or user flows that depended on that route.
  2. The changes to the layout and content might require updates to existing documentation or user guides.

Security Hotspots

None identified. The changes are primarily focused on UI and content updates, with no apparent security implications.

@IanKrieger IanKrieger merged commit d45a2cb into master Aug 5, 2024
8 checks passed
@IanKrieger IanKrieger deleted the feat/update-search-landing-page branch August 5, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Search Registration Page
3 participants