Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Production Release 2024-08-06 #1300

Merged
merged 2 commits into from
Aug 6, 2024
Merged

Production Release 2024-08-06 #1300

merged 2 commits into from
Aug 6, 2024

Conversation

IanKrieger
Copy link
Member

@IanKrieger IanKrieger commented Aug 5, 2024

@IanKrieger IanKrieger requested a review from a team as a code owner August 5, 2024 13:40
@github-actions github-actions bot changed the title Prod Release (NEXT) Production Release 2024-08-05 Aug 5, 2024
Copy link

github-actions bot commented Aug 5, 2024

[puLL-Merge] - brave/ads-ui@1300

Description

This PR makes significant changes to the Brave Search Ads landing page, registration process, and campaign management functionality. It updates the UI, improves user experience, and refines the campaign validation logic.

Changes

Changes

  1. src/assets/videos/setting_up_brave_search_ads.mp4:

    • Added a new video asset for setting up Brave Search Ads.
  2. src/auth/registration/Register.tsx:

    • Removed the SearchRegister component.
    • Added a redirect from "/register/search" to "/search".
  3. src/auth/registration/SearchForm.tsx:

    • Modified the width of the form to a fixed 375px.
  4. src/auth/registration/SearchRegister.tsx:

    • Redesigned the registration form with a new layout and styling.
    • Added a video preview and updated the content.
  5. src/basic-attention-token/PrivacyPolicy.tsx:

    • Updated the typography variant for search-specific privacy policy.
  6. src/components/Campaigns/CampaignDateRange.tsx:

    • Added a warning message when the campaign might end prematurely due to budget constraints.
  7. src/locales/*.po:

    • Updated translations for various languages.
  8. src/search/SearchLandingPage.tsx:

    • Completely redesigned the Search landing page with new content, layout, and video integration.
  9. src/search/SearchTalkingPoints.tsx:

    • Updated the talking points with new content and styling.
  10. src/user/library/index.ts, src/user/views/adsManager/types/index.ts, src/validation/CampaignSchema.tsx:

    • Removed the validateStart field from campaign forms and validation.
  11. src/util/campaign.ts:

    • Added a new function isFuzzyCalculatedDailyBudgetOk to check if the campaign budget is sufficient for the given date range.
  12. src/validation/CampaignSchema.tsx:

    • Updated the campaign validation schema to use the new isFuzzyCalculatedDailyBudgetOk function.
    • Modified the start date validation to only apply for new campaigns.

Possible Issues

  1. The fixed width of 375px for the SearchForm might not be responsive on all device sizes.
  2. The removal of the validateStart field might affect existing campaigns or integrations that rely on this field.

Security Hotspots

No significant security hotspots were identified in this PR.

@github-actions github-actions bot changed the title Production Release 2024-08-05 Production Release 2024-08-06 Aug 6, 2024
@IanKrieger IanKrieger added this pull request to the merge queue Aug 6, 2024
Merged via the queue into prod with commit f82b411 Aug 6, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants