This repository has been archived by the owner on Apr 25, 2024. It is now read-only.
Updating our snapcraft.yaml file #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding missing package for brave/brave-browser#13064
|
Neat. Thanks for taking this up. How did you test this? |
mihaiplesa
approved these changes
Dec 11, 2020
The snap was built with: I tested this on an Ubuntu 20.04 by installing it locally. |
posix4e
reviewed
Dec 11, 2020
posix4e
reviewed
Dec 11, 2020
|
Tested Brave Rewards (survives restart) and DRM content. |
Brave uses xdg-open so the xdg-email part is unneeded. Removing personal-files interface where config is stored outside the snap.
mihaiplesa
approved these changes
Dec 11, 2020
bkero
approved these changes
Dec 11, 2020
fmarier
reviewed
Dec 11, 2020
| plugs: | ||
| - avahi-observe |
There was a problem hiding this comment.
Might be worth testing to see if you can see local printers without avahi.
There was a problem hiding this comment.
I don't have the means to test this. I can follow up in a further QA ticket.
This was referenced Dec 28, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I updated out snapcraft.yaml file based on the Chromium snapcraft file that had support for Web Bluetooth and WebUSB.
I also explicitly added
fonts-liberationsinto the snap in an attempt to fix: brave/brave-browser#13064