Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Desktop] brave://crashes has a "Provide additional details" button that links to chromium bug reporting #10185

Closed
LaurenWags opened this issue Jun 9, 2020 · 2 comments · Fixed by brave/brave-core#5798

Comments

@LaurenWags
Copy link
Member

Description

brave://crashes page w/ C83 now contains a 'Provide additional details' button that directs the user to chromium in order to report on additional crash details.

C81 version did not have this button on brave://crashes.

Steps to Reproduce

  1. If not enabled, enable sending of crash reports in settings.
  2. Navigate to brave://crash
  3. Naivgate to brave://crashes
  4. Click on Provide additional details button

Actual result:

Button directs you to bugs.chromium.org and prompts you to login to google.
Screen Shot 2020-06-09 at 3 42 49 PM

Screen Shot 2020-06-09 at 3 51 10 PM

Expected result:

Button should either be removed (as it was in 1.9.x/C81 as below) or link to one of our pages.

Screen Shot 2020-06-09 at 3 40 57 PM

Reproduces how often:

easily

Brave version (brave://version info)

Brave 1.10.86 Chromium: 83.0.4103.61 (Official Build) (64-bit)
Revision 94f915a8d7c408b09cc7352161ad592299f384d2-refs/branch-heads/4103@{#561}
OS macOS Version 10.14.6 (Build 18G3020)

Version/Channel Information:

  • Can you reproduce this issue with the current release?
  • Can you reproduce this issue with the beta channel?
  • Can you reproduce this issue with the dev channel?
  • Can you reproduce this issue with the nightly channel?

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

cc @rebron @bsclifton @mkarolin @brave/legacy_qa

@LaurenWags LaurenWags added bug release/blocking about-pages/rebrand Rebranding work on top of Chrome's Polymer-powered pages QA/Yes google OS/Desktop labels Jun 9, 2020
@LaurenWags LaurenWags added this to the 1.10.x - Release milestone Jun 9, 2020
@mkarolin mkarolin self-assigned this Jun 9, 2020
mkarolin added a commit to brave/brave-core that referenced this issue Jun 10, 2020
mkarolin added a commit to brave/brave-core that referenced this issue Jun 10, 2020
On Crashes page after submitting a crash a button appears that allows
submit a bug with additional details. Instead of directing the user to
bugs.chromium.org we will redirect them to
github.com/brave/brave-browser/issues/new and prefill some of the issue
info.

Fixes brave/brave-browser#10185
@btlechowski
Copy link

Testing is blocked on Linux due to #4296. I marked this issue as OS/macOS and OS/Windows.

@LaurenWags
Copy link
Member Author

LaurenWags commented Jun 12, 2020

Verified passed with

Brave | 1.10.90 Chromium: 83.0.4103.97 (Official Build) (64-bit)
-- | --
Revision | 326d148b9655369b86498d9ecca39f63dd2bdd2d-refs/branch-heads/4103@{#657}
OS | macOS Version 10.14.6 (Build 18G3020)

Example:
Here are some crash reports I generated and confirmed on the server:
Screen Shot 2020-06-12 at 10 02 12 AM
After clicking the Provide additional details button and logging into GH when prompted, issue is autopopulated as below:
Screen Shot 2020-06-12 at 10 03 36 AM


Verification passed on

Brave | 1.10.90 Chromium: 83.0.4103.97 (Official Build) (64-bit)
-- | --
Revision | 326d148b9655369b86498d9ecca39f63dd2bdd2d-refs/branch-heads/4103@{#657}
OS | Windows 8.1 (Build 9600.19573)

Created the following crashes and ensured they appeared in BackTrace

fc5b0000-1c55-8704-0000-000000000000
ed5c0000-1c55-8704-0000-000000000000

image

image


Verified PASSED on Win 10 x64 using the following build:

Brave | 1.10.90 Chromium: 83.0.4103.97 (Official Build) (64-bit)
--- | ---
Revision | 326d148b9655369b86498d9ecca39f63dd2bdd2d-refs/branch-heads/4103@{#657}
OS | Windows 10 OS Version 2004 (Build 19041.329)

Example:

Here are some crash reports I generated and confirmed on the server:

crashReports

After clicking the Provide additional details button and logging into GH when prompted, issue is autopopulated as below:

GHCrashRedirect

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment