Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redirects additional details button target URL on crashes page (1.10.x). #5815

Merged
merged 1 commit into from
Jun 12, 2020

Conversation

mkarolin
Copy link
Collaborator

Fixes brave/brave-browser#10185
Uplift from #5798

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

Redirects additional details button target URL on crashes page.
@mkarolin mkarolin added this to the 1.10.x - Release milestone Jun 11, 2020
@mkarolin mkarolin requested a review from a team June 11, 2020 14:10
@mkarolin mkarolin self-assigned this Jun 11, 2020
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.10.x approved after deliberating with @brave/uplift-approvers. QA went verified the PR on Nightly as per #5798 (comment).

@kjozwiak kjozwiak merged commit 4f25a00 into 1.10.x Jun 12, 2020
@kjozwiak kjozwiak deleted the maxk-fix-crashes-details-1.10.x branch June 12, 2020 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants