Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Desktop] Wallet summary display on brave://rewards needs to be adjusted for 3 decimal places #10446

Closed
LaurenWags opened this issue Jun 24, 2020 · 1 comment · Fixed by brave/brave-core#5971

Comments

@LaurenWags
Copy link
Member

Description

Found while testing #10027 on Nightly

Now that we display 3 decimal places for Rewards, it looks like the line items on the wallet summary panel are displaying on 2 lines. This isn't happening on the summary from the BAT logo though.

Steps to Reproduce

  1. Launch w/ staging flags
  2. Claim UGP grant
  3. Tip, AC, etc.
  4. View brave://rewards page and panel.

Actual result:

Screen Shot 2020-06-24 at 2 06 42 PM

Expected result:

both summaries to look the same

Reproduces how often:

easily

Brave version (brave://version info)

Brave 1.12.48 Chromium: 83.0.4103.116 (Official Build) nightly (64-bit)
Revision 8f0c18b4dca9b6699eb629be0f51810c24fb6428-refs/branch-heads/4103@{#716}
OS macOS Version 10.14.6 (Build 18G3020)

Version/Channel Information:

  • Can you reproduce this issue with the current release? n/a
  • Can you reproduce this issue with the beta channel? n/a
  • Can you reproduce this issue with the dev channel? n/a
  • Can you reproduce this issue with the nightly channel? yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@LaurenWags
Copy link
Member Author

LaurenWags commented Jul 17, 2020

Verified passed with

Brave | 1.12.92 Chromium: 84.0.4147.89 (Official Build) dev (64-bit)
-- | --
Revision | 19abfe7bcba9318a0b2a6bc6634a67fc834aa592-refs/branch-heads/4147@{#852}
OS | macOS Version 10.14.6 (Build 18G3020)

Screen Shot 2020-07-17 at 2 38 02 PM


Verification passed on


Brave | 1.12.94 Chromium: 84.0.4147.89 (Official Build) dev (64-bit)
-- | --
Revision | 19abfe7bcba9318a0b2a6bc6634a67fc834aa592-refs/branch-heads/4147@{#852}
OS | Windows 10 OS Version 1903 (Build 18362.959)


brave://rewards BR panel
image image

Verification passed on

Brave 1.12.99 Chromium: 84.0.4147.89 (Official Build) dev (64-bit)
Revision 19abfe7bcba9318a0b2a6bc6634a67fc834aa592-refs/branch-heads/4147@{#852}
OS Ubuntu 18.04 LTS
image image

@rebron rebron changed the title [Desktop] wallet summary display on brave://rewards needs to be adjusted for 3 decimal places [Desktop] Wallet summary display on brave://rewards needs to be adjusted for 3 decimal places Aug 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment