Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust wallet summary styles to display BAT and fiat on same line #5971

Merged
merged 1 commit into from
Jun 30, 2020

Conversation

zenparsing
Copy link
Collaborator

Resolves brave/brave-browser#10446

The UI difference between the rewards popup and rewards page was caused by a media query that created a larger "flex-basis" in the popup case. This PR removes the media query and simplifies the CSS flex properties.

Submitter Checklist:

Test Plan:

  • Launch w/ staging flags.
  • Claim UGP grant.
  • Tip a publisher.
  • Navigate to brave://rewards page.
    • Verify that wallet summary amounts are displayed on a single line.
  • Open brave rewards popup.
    • Verify that wallet summary amounts are displayed on a single line.

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@zenparsing zenparsing added feature/rewards CI/skip Do not run CI builds (except noplatform) labels Jun 29, 2020
@zenparsing zenparsing self-assigned this Jun 29, 2020
@zenparsing zenparsing force-pushed the ksmith-wallet-summary-same-line branch from 15a7077 to 2360dc8 Compare June 29, 2020 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip Do not run CI builds (except noplatform) feature/rewards
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Desktop] Wallet summary display on brave://rewards needs to be adjusted for 3 decimal places
2 participants