Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand Rewards to three decimal places #5699

Merged
merged 1 commit into from
Jun 5, 2020
Merged

Expand Rewards to three decimal places #5699

merged 1 commit into from
Jun 5, 2020

Conversation

tmancey
Copy link
Collaborator

@tmancey tmancey commented Jun 1, 2020

Resolves brave/brave-browser#10027

Submitter Checklist:

Test Plan:

See brave/brave-browser#10027

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@tmancey tmancey self-assigned this Jun 1, 2020
@tmancey tmancey changed the title Expand estimated pending rewards to two decimal places Expand Rewards to two decimal places Jun 2, 2020
@moritzhaller moritzhaller self-requested a review June 2, 2020 12:31
@tmancey tmancey added the CI/skip Do not run CI builds (except noplatform) label Jun 2, 2020
@tmancey tmancey removed the CI/skip Do not run CI builds (except noplatform) label Jun 2, 2020
@tmancey tmancey changed the title Expand Rewards to two decimal places Expand Rewards to 3 decimal places Jun 2, 2020
@tmancey tmancey changed the title Expand Rewards to 3 decimal places Expand Rewards to three decimal places Jun 2, 2020
@tmancey tmancey added the CI/skip Do not run CI builds (except noplatform) label Jun 2, 2020
@tmancey tmancey force-pushed the issues/10027 branch 2 times, most recently from 3a7a3af to 6c8e036 Compare June 2, 2020 14:39
@tmancey tmancey removed the CI/skip Do not run CI builds (except noplatform) label Jun 2, 2020
@tmancey
Copy link
Collaborator Author

tmancey commented Jun 2, 2020

Failed CI for Linux and macOS, restarting

@tmancey tmancey added CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 labels Jun 2, 2020
@tmancey tmancey added CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS CI/skip-windows and removed CI/skip-macos-x64 Do not run CI builds for macOS x64 labels Jun 2, 2020
@tmancey tmancey force-pushed the issues/10027 branch 2 times, most recently from 7b1ee5f to e2849b8 Compare June 4, 2020 09:22
Copy link
Contributor

@NejcZdovc NejcZdovc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NejcZdovc
Copy link
Contributor

NejcZdovc commented Jun 4, 2020

PR looks good to me. Waiting for confirmation from design team

@tmancey tmancey force-pushed the issues/10027 branch 2 times, most recently from c8c6992 to 8795f4b Compare June 4, 2020 10:11
Copy link
Contributor

@NejcZdovc NejcZdovc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please fix browser tests

@tmancey tmancey force-pushed the issues/10027 branch 2 times, most recently from ca1b91a to 6c159db Compare June 4, 2020 22:25
@tmancey tmancey requested a review from NejcZdovc June 4, 2020 22:36
@tmancey tmancey removed CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS CI/skip-windows labels Jun 4, 2020
@tmancey tmancey merged commit 8520102 into master Jun 5, 2020
@tmancey tmancey deleted the issues/10027 branch June 5, 2020 09:21
@tmancey tmancey added this to the 1.12.x - Nightly milestone Jun 5, 2020
@tmancey
Copy link
Collaborator Author

tmancey commented Jun 5, 2020

CI failed for known test-install issue

@LaurenWags
Copy link
Member

Verified using

Brave | 1.12.48 Chromium: 83.0.4103.116 (Official Build) nightly (64-bit)
-- | --
Revision | 8f0c18b4dca9b6699eb629be0f51810c24fb6428-refs/branch-heads/4103@{#716}
OS | macOS Version 10.14.6 (Build 18G3020)

The following areas of the UI were checked to confirm 3 decimal places were shown (note, not all screenshots were taken using the same profile).

  1. Auto Contribute Panel on brave://rewards

Screen Shot 2020-06-24 at 1 59 54 PM

Screen Shot 2020-06-24 at 2 00 03 PM

  1. Tip panels on brave://rewards

Screen Shot 2020-06-24 at 2 07 47 PM

  1. Rewards Widget on NTP:

Screen Shot 2020-06-24 at 2 08 11 PM

Screen Shot 2020-06-24 at 2 12 23 PM

  1. Claiming Ad or UGP grant:

Screen Shot 2020-06-24 at 2 00 50 PM

Screen Shot 2020-06-24 at 2 14 37 PM

  1. Wallet summary panel on brave://rewards

Screen Shot 2020-06-24 at 2 03 55 PM

  1. Tip banners (one time and recurring for both before and after tipping):

Screen Shot 2020-06-24 at 2 04 31 PM

Screen Shot 2020-06-24 at 2 04 49 PM

Screen Shot 2020-06-24 at 2 05 22 PM

Screen Shot 2020-06-24 at 2 05 32 PM

  1. Summary from BAT logo:

Screen Shot 2020-06-24 at 2 05 11 PM

  1. Monthly Statement:

Screen Shot 2020-06-24 at 2 07 21 PM

Screen Shot 2020-06-24 at 2 07 28 PM

Screen Shot 2020-06-24 at 2 22 22 PM

Screen Shot 2020-06-24 at 2 22 29 PM

Screen Shot 2020-06-24 at 2 22 36 PM

  1. Ad panel on brave://rewards:

Screen Shot 2020-06-24 at 2 12 15 PM

  1. Recurring tip amount display on panel:

Screen Shot 2020-06-24 at 2 33 21 PM

Logged follow up issues for the wallet summary on brave://rewards page going to 2 lines but summary on panel stays on one line - brave/brave-browser#10446
Screen Shot 2020-06-24 at 2 06 42 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Desktop] Expand Rewards to three decimal places
4 participants