-
Notifications
You must be signed in to change notification settings - Fork 878
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expand Rewards to three decimal places #5699
Conversation
components/brave_rewards/resources/android_page/components/promotion.tsx
Outdated
Show resolved
Hide resolved
components/brave_rewards/resources/page/components/promotion.tsx
Outdated
Show resolved
Hide resolved
components/brave_rewards/resources/tip/components/siteBanner.tsx
Outdated
Show resolved
Hide resolved
components/brave_rewards/resources/ui/components/walletSummary/index.tsx
Outdated
Show resolved
Hide resolved
components/brave_rewards/resources/android_page/components/promotion.tsx
Outdated
Show resolved
Hide resolved
3a7a3af
to
6c8e036
Compare
Failed CI for Linux and macOS, restarting |
7b1ee5f
to
e2849b8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR looks good to me. Waiting for confirmation from design team |
c8c6992
to
8795f4b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please fix browser tests
ca1b91a
to
6c159db
Compare
CI failed for known test-install issue |
Verified using
The following areas of the UI were checked to confirm 3 decimal places were shown (note, not all screenshots were taken using the same profile).
Logged follow up issues for the wallet summary on brave://rewards page going to 2 lines but summary on panel stays on one line - brave/brave-browser#10446 |
Resolves brave/brave-browser#10027
Submitter Checklist:
npm run lint
)git rebase master
(if needed).git rebase -i
to squash commits (if needed).Test Plan:
See brave/brave-browser#10027
Reviewer Checklist:
After-merge Checklist:
changes has landed on.