Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand Rewards to three decimal places - 1.11.x #5835

Merged
merged 1 commit into from
Jun 25, 2020
Merged

Conversation

tmancey
Copy link
Collaborator

@tmancey tmancey commented Jun 13, 2020

Uplift of #5699
Resolves brave/brave-browser#10027

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@tmancey tmancey requested a review from a team June 13, 2020 12:16
@tmancey tmancey requested a review from NejcZdovc as a code owner June 13, 2020 12:16
@tmancey tmancey self-assigned this Jun 13, 2020
@tmancey tmancey added this to the 1.11.x - Beta milestone Jun 13, 2020
@NejcZdovc NejcZdovc removed their request for review June 13, 2020 16:11
@tmancey tmancey added CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS CI/skip-windows labels Jun 15, 2020
@tmancey
Copy link
Collaborator Author

tmancey commented Jun 15, 2020

CI failed on Linux and macOS, restarting

@tmancey tmancey force-pushed the issues/10027-1.11.x branch 2 times, most recently from f29cfa7 to e481d8f Compare June 17, 2020 07:11
@tmancey tmancey changed the title Expand Rewards to three decimal places Expand Rewards to three decimal places - 1.11.x Jun 17, 2020
@tmancey tmancey removed CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS CI/skip-windows labels Jun 17, 2020
@kjozwiak
Copy link
Member

Looks like test-browser failed on both Linux & macOS as per https://ci.brave.com/job/pr-brave-browser-issues-10027-1.11.x/6/execution/node/391/log/ & https://ci.brave.com/job/pr-brave-browser-issues-10027-1.11.x/6/execution/node/450/log/. Example:

04:10:15  ../../brave/components/brave_rewards/browser/rewards_service_browsertest_utils.cc:123: Failure
04:10:15  Expected equality of these values:
04:10:15    true
04:10:15    result
04:10:15      Which is: a JavaScript error:
04:10:15  Error: Timed out waiting for '[data-test-id='activity-table-body'] tr:nth-of-type(1) td:nth-of-type(3)' to equal '20.0BAT28.60 USD'
04:10:15      at eval (__const_std::string&_script__:45:24)
04:10:15  
04:10:15  Stack trace:
04:10:15  #0 0x5602b5ae49e9 (/home/ubuntu/jenkins/workspace/pr-brave-browser-issues-10027-1.11.x/src/out/Release/brave_browser_tests+0x5b999e8)
04:10:15  
04:10:15  ../../brave/components/brave_rewards/browser/rewards_service_browsertest_utils.cc:123: Failure
04:10:15  Expected equality of these values:
04:10:15    true
04:10:15    result
04:10:15      Which is: a JavaScript error:
04:10:15  Error: Timed out waiting for '[data-test-id='activity-table-body'] tr:nth-of-type(2) td:nth-of-type(3)' to equal '30.0BAT42.90 USD'
04:10:15      at eval (__const_std::string&_script__:45:24)
04:10:15  
04:10:15  Stack trace:
04:10:15  #0 0x5602b5ae49e9 (/home/ubuntu/jenkins/workspace/pr-brave-browser-issues-10027-1.11.x/src/out/Release/brave_browser_tests+0x5b999e8)
04:10:15  
04:10:15  [  FAILED  ] BraveRewardsBrowserTest.SplitProcessOneTimeTip, where TypeParam =  and GetParam() =  (12060 ms)
04:10:15  [596/596] BraveRewardsBrowserTest.SplitProcessOneTimeTip (12319 ms)
04:10:15  1 test failed:
04:10:15      BraveRewardsBrowserTest.SplitProcessOneTimeTip (../../brave/components/brave_rewards/browser/rewards_service_browsertest.cc:2936)

I haven't seen the above failure before. @NejcZdovc is this a known intermittent issue? Possible that the above PR regressed BraveRewardsBrowserTest.SplitProcessOneTimeTip?

@kjozwiak
Copy link
Member

@tmancey looks like CI/skip-android, CI/skip-ios, and CI/skip-windows were removed ~8 days ago as per #5835 (comment). However, https://ci.brave.com/job/pr-brave-browser-issues-10027-1.11.x/6/ looks like the last run which skipped the above platforms. Was the above also meant to run on these? Maybe the labels were removed after the 6th was restarted/relaunched?

@NejcZdovc
Copy link
Contributor

@tmancey you need do adjust values for SplitProcessOneTimeTip test as well. Currently they are set to 1 decimal place

Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.11.x approved after deliberating with @brave/uplift-approvers. QA went through the PR on Nightly as per #5699 (comment).

@kjozwiak kjozwiak merged commit 1f40c5f into 1.11.x Jun 25, 2020
@kjozwiak kjozwiak deleted the issues/10027-1.11.x branch June 25, 2020 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants