Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Desktop] Purchase intent does not work if Brave is set to JP locale #10737

Closed
btlechowski opened this issue Jul 14, 2020 · 2 comments · Fixed by brave/brave-core#6076
Closed

Comments

@btlechowski
Copy link

btlechowski commented Jul 14, 2020

Follow up to: #10235

Issue found by @LaurenWags.

Important: This issue is reproducible on 1.11.x and 1.12.x. Not reproducible on 1.13.x.

Steps to Reproduce

  1. Run Brave in JP locale
  2. Try to trigger purchase intent
  3. Check Default/ads_service/client.json for purchaseIntentSignalHistory

Actual result:

purchaseIntentSignalHistory is empty
"purchaseIntentSignalHistory":{}

Note: issue does not reproduce when locale is set to US.

Expected result:

purchaseIntentSignalHistory is not empty

Reproduces how often:

100% repro rate

Brave version (brave://version info)

Reproducible on

Brave 1.11.96 Chromium: 84.0.4147.89 (Official Build) (64-bit)
Revision 19abfe7bcba9318a0b2a6bc6634a67fc834aa592-refs/branch-heads/4147@{#852}
OS Ubuntu 18.04 LTS
Brave 1.12.85 Chromium: 84.0.4147.85 (Official Build) dev (64-bit)
Revision e20c13e958edc3707db3d26d513780a7f6331a4b-refs/branch-heads/4147@{#837}
OS Ubuntu 18.04 LTS

Not reproducible on

Brave 1.13.13 Chromium: 84.0.4147.89 (Official Build) nightly (64-bit)
Revision 19abfe7bcba9318a0b2a6bc6634a67fc834aa592-refs/branch-heads/4147@{#852}
OS Ubuntu 18.04 LTS

cc @brave/legacy_qa @moritzhaller @jsecretan @rebron

@LaurenWags
Copy link
Member

Reproduced on macOS using

Brave | 1.11.96 Chromium: 84.0.4147.89 (Official Build) (64 ビット)
-- | --
変更履歴 | 19abfe7bcba9318a0b2a6bc6634a67fc834aa592-refs/branch-heads/4147@{#852}
OS | macOS バージョン10.14.6(ビルド18G3020)

Did not reproduce on macOS with

Brave | 1.13.13 Chromium: 84.0.4147.89 (Official Build) nightly (64 ビット)
-- | --
変更履歴 | 19abfe7bcba9318a0b2a6bc6634a67fc834aa592-refs/branch-heads/4147@{#852}
OS | macOS バージョン10.14.6(ビルド18G3020)

@LaurenWags
Copy link
Member

LaurenWags commented Jul 15, 2020

Verified passed with

Brave	1.11.97 Chromium: 84.0.4147.89 (Official Build) (64 ビット)
変更履歴	19abfe7bcba9318a0b2a6bc6634a67fc834aa592-refs/branch-heads/4147@{#852}
OS	macOS バージョン10.14.6(ビルド18G3020)
  • Verified STR from description
  • Confirmed if configured for Japan locale (see me for details if needed), I was able to trigger an ad based on a subset of the new segments for Japan.
  • Staging catalog/env was used for testing

Keyword example:

  1. Searched on google.co.jp for a keyword from the list
  2. Saw the below in the logs as expected:
[17922:775:0715/074216.183600:VERBOSE1:ads_impl.cc(697)] Extracting purchase intent signal from visited URL
  1. Saw the below in my client.json file:
  "purchaseIntentSignalHistory": {
    "jp trial 1-search related word": [
      {
        "timestamp_in_seconds": 1594813336,
        "weight": 1
      }
    ]
  },
  1. Triggered an ad and saw the below in the logs (note, ad triggers with weight of 1 as expected):
[17922:775:0715/074246.802084:VERBOSE1:ads_impl.cc(826)] Serving ad from categories:
[17922:775:0715/074246.802159:VERBOSE1:ads_impl.cc(828)]   jp trial 1-search related word
[17922:775:0715/074246.803264:VERBOSE2:ads_impl.cc(988)] 1 eligible ads with a priority of 1
[17922:775:0715/074246.803323:VERBOSE1:ads_impl.cc(940)] Found 1 eligible ads
[17922:775:0715/074246.803363:VERBOSE3:client.cc(580)] Saving client state
[17922:775:0715/074246.803426:VERBOSE3:client.cc(580)] Saving client state
[17922:775:0715/074246.803488:VERBOSE3:client.cc(580)] Saving client state
[17922:775:0715/074246.803541:VERBOSE3:client.cc(580)] Saving client state
[17922:775:0715/074246.803592:VERBOSE1:ads_impl.cc(1256)] Ad notification shown:
  uuid: 42151195-fa62-4dad-b514-12b77af3d197
  parentUuid: 143b96c3-a9d6-4c47-a0f1-d50daa8933a1
  creativeInstanceId: 2cdbca84-3c4a-42cc-a8af-9423808517ef
  creativeSetId: a0b2e3e8-8847-4267-adfb-f41e701644ce
  category: jp trial 1-search related word
  1. Since the category of jp trial 1-search related word matches the the segment of the keyword I searched for test passes.

Website example:

  1. Visited an a site from the list
  2. Saw the below in my logs as expected:
[18009:775:0715/075934.583874:VERBOSE1:ads_impl.cc(697)] Extracting purchase intent signal from visited URL
  1. Saw the below in my client.json file:
  "purchaseIntentSignalHistory": {
    "jp trial 3-related content of loan": [
      {
        "timestamp_in_seconds": 1594814374,
        "weight": 1
      }
    ]
  },
  1. Triggered an ad and saw the below in the logs (note, ad triggers with weight of 1 as expected):
[18009:775:0715/080129.959188:VERBOSE1:ads_impl.cc(826)] Serving ad from categories:
[18009:775:0715/080129.959261:VERBOSE1:ads_impl.cc(828)]   jp trial 3-related content of loan
[18009:775:0715/080129.960582:VERBOSE2:ads_impl.cc(988)] 1 eligible ads with a priority of 1
[18009:775:0715/080129.960638:VERBOSE1:ads_impl.cc(940)] Found 1 eligible ads
[18009:775:0715/080129.960680:VERBOSE3:client.cc(580)] Saving client state
[18009:775:0715/080129.960752:VERBOSE3:client.cc(580)] Saving client state
[18009:775:0715/080129.960808:VERBOSE3:client.cc(580)] Saving client state
[18009:775:0715/080129.960862:VERBOSE3:client.cc(580)] Saving client state
[18009:775:0715/080129.960919:VERBOSE1:ads_impl.cc(1256)] Ad notification shown:
  uuid: 7524c8e6-4c8a-4702-ab2e-6e6bd13d1dcb
  parentUuid: afc4dc26-140f-4a36-b210-7aaab7b2f0c4
  creativeInstanceId: 20228e89-448d-4c3b-a869-ec477b9321f7
  creativeSetId: 7f6117a1-fb7b-4579-868c-118fcca3c55f
  category: jp trial 3-related content of loan
  1. Since the category of jp trial 3-related content of loan matches the the segment of the website I visited, test passes.

Verification passed on

Brave 1.11.97 Chromium: 84.0.4147.89 (Official Build) (64-bit)
Revision 19abfe7bcba9318a0b2a6bc6634a67fc834aa592-refs/branch-heads/4147@{#852}
OS Ubuntu 18.04 LTS

Verified purchase intent is increased for segment: jp trial 1-search related word by searching for 中古車買取. Verified ad is triggered.

"purchaseIntentSignalHistory":{"jp trial 1-search related word":[{"timestamp_in_seconds":1594815840,"weight":1}]}

Verified purchase intent is increased for segment: jp trial 3-domain of competitors by opening https://www.aiful.co.jp. Verified ad is triggered.


Verification passed on


Brave | 1.11.97 Chromium: 84.0.4147.89 (Official Build) (64-bit)
-- | --
Revision | 19abfe7bcba9318a0b2a6bc6634a67fc834aa592-refs/branch-heads/4147@{#852}
OS | Windows 10 OS Version 1903 (Build 18362.959)


  • Verified STR from description
  • Verified that for Japan locale ad can be triggered and logs are shown as expected and ensured purchaseIntentSignalHistory is not empty

Keyword 1: LinkedIn

  1. Ad is triggered for the segment jp trial 2-search competitor word
  2. Logs are shown as expected
 "purchaseIntentSignalHistory": {
    "jp trial 2-search competitor word": [
      {
        "timestamp_in_seconds": 1594898449,
        "weight": 1
      }
    ]
  },
[16840:17252:0716/165049.384:VERBOSE1:ads_impl.cc(697)] Extracting purchase intent signal from visited URL
[16840:17252:0716/165112.191:VERBOSE1:ads_impl.cc(826)] Serving ad from categories:
[16840:17252:0716/165112.191:VERBOSE1:ads_impl.cc(828)]   jp trial 2-search competitor word
[16840:17252:0716/165112.194:VERBOSE2:ads_impl.cc(988)] 1 eligible ads with a priority of 1
[16840:17252:0716/165112.194:VERBOSE1:ads_impl.cc(940)] Found 1 eligible ads
[16840:17252:0716/165112.194:VERBOSE3:client.cc(580)] Saving client state
[16840:17252:0716/165112.194:VERBOSE3:client.cc(580)] Saving client state
[16840:17252:0716/165112.194:VERBOSE3:client.cc(580)] Saving client state
[16840:17252:0716/165112.194:VERBOSE3:client.cc(580)] Saving client state
[16840:17252:0716/165112.194:VERBOSE1:ads_impl.cc(1256)] Ad notification shown:
  uuid: fe3c6240-07df-4a4b-b422-0521911d6c1b
  parentUuid: f14de5bd-edf4-4a1d-aac6-8a7ae41a1e36
  creativeInstanceId: 6a302399-5872-4b29-a245-21920b449a73
  creativeSetId: 5762d2a3-a86e-40fd-a648-1505a8a90e3c
  category: jp trial 2-search competitor word
  title: DODA Test Creative
  body: DODA Test Creative
  targetUrl: https://www.brave.com
[16840:17252:0716/165112.194:VERBOSE1:ads_service_impl.cc(1897)] Timeout ad notification with uuid fe3c6240-07df-4a4b-b422-0521911d6c1b in 120 seconds
[16840:17252:0716/165112.194:VERBOSE3:ad_notifications.cc(307)] Saving ad notifications state
[16840:17252:0716/165112.195:VERBOSE3:ad_notification_event_viewed.cc(32)] Event log: {"data":{"type":"restart","timestamp":"0 hours, 0 minutes, 0 seconds at 4:51 PM"},"data":{"type":"notify","timestamp":"0 hours, 0 minutes, 0 seconds at 4:51 PM","eventType":"generated","classifications":["jp trial 2","search competitor word"],"adCatalog":"5762d2a3-a86e-40fd-a648-1505a8a90e3c","targetUrl":"https://www.brave.com"}}
[16840:17252:0716/165112.195:VERBOSE3:ads_impl.cc(1439)] Event log: {"data":{"type":"confirmation","timestamp":"0 hours, 0 minutes, 0 seconds at 4:51 PM","creativeInstanceId":"6a302399-5872-4b29-a245-21920b449a73","confirmationType":"view"}}
[16840:17252:0716/165112.195:VERBOSE3:client.cc(580)] Saving client state
[16840:17252:0716/165112.196:VERBOSE1:confirmations_impl.cc(1161)] Confirm ad:
  creativeInstanceId: 6a302399-5872-4b29-a245-21920b449a73
  creativeSetId: 5762d2a3-a86e-40fd-a648-1505a8a90e3c
  category: jp trial 2-search competitor word
  targetUrl: https://www.brave.com
  geoTarget: JP
  confirmationType: view

Keyword 2: auじぶん銀行カードローン

  1. Ad is triggered for the segment jp trial 3-search competitor word
  2. Logs are shown as expected
[9816:13576:0716/165630.214:VERBOSE1:ads_impl.cc(697)] Extracting purchase intent signal from visited URL
 "purchaseIntentSignalHistory": {
    "jp trial 3-search competitor word": [
      {
        "timestamp_in_seconds": 1594898790,
        "weight": 1
      },
      {
        "timestamp_in_seconds": 1594898834,
        "weight": 1
      }
    ]
  },
[9816:13576:0716/165739.448:VERBOSE1:ads_impl.cc(826)] Serving ad from categories:
[9816:13576:0716/165739.448:VERBOSE1:ads_impl.cc(828)]   jp trial 3-search competitor word
[9816:13576:0716/165739.449:VERBOSE2:ads_impl.cc(988)] 1 eligible ads with a priority of 1
[9816:13576:0716/165739.449:VERBOSE1:ads_impl.cc(940)] Found 1 eligible ads
[9816:13576:0716/165739.449:VERBOSE3:client.cc(580)] Saving client state
[9816:13576:0716/165739.449:VERBOSE3:client.cc(580)] Saving client state
[9816:13576:0716/165739.449:VERBOSE3:client.cc(580)] Saving client state
[9816:13576:0716/165739.449:VERBOSE3:client.cc(580)] Saving client state
[9816:13576:0716/165739.449:VERBOSE1:ads_impl.cc(1256)] Ad notification shown:
  uuid: 3b988e3f-23a0-49e1-aa81-7409923d50a9
  parentUuid: 60f76e06-e6e2-4b4b-b4bd-76133905d374
  creativeInstanceId: 20228e89-448d-4c3b-a869-ec477b9321f7
  creativeSetId: 7f6117a1-fb7b-4579-868c-118fcca3c55f
  category: jp trial 3-search competitor word
  title: Test Creative for ACOM Segment
  body: Test Creative for ACOM Segment
  targetUrl: https://www.brave.com
[9816:13576:0716/165739.449:VERBOSE1:ads_service_impl.cc(1897)] Timeout ad notification with uuid 3b988e3f-23a0-49e1-aa81-7409923d50a9 in 120 seconds
[9816:13576:0716/165739.449:VERBOSE3:ad_notifications.cc(307)] Saving ad notifications state
[9816:13576:0716/165739.449:VERBOSE3:ad_notification_event_viewed.cc(32)] Event log: {"data":{"type":"restart","timestamp":"0 hours, 0 minutes, 0 seconds at 4:57 PM"},"data":{"type":"notify","timestamp":"0 hours, 0 minutes, 0 seconds at 4:57 PM","eventType":"generated","classifications":["jp trial 3","search competitor word"],"adCatalog":"7f6117a1-fb7b-4579-868c-118fcca3c55f","targetUrl":"https://www.brave.com"}}
[9816:13576:0716/165739.450:VERBOSE3:ads_impl.cc(1439)] Event log: {"data":{"type":"confirmation","timestamp":"0 hours, 0 minutes, 0 seconds at 4:57 PM","creativeInstanceId":"20228e89-448d-4c3b-a869-ec477b9321f7","confirmationType":"view"}}
[9816:13576:0716/165739.450:VERBOSE3:client.cc(580)] Saving client state
[9816:13576:0716/165739.450:VERBOSE1:confirmations_impl.cc(1161)] Confirm ad:
  creativeInstanceId: 20228e89-448d-4c3b-a869-ec477b9321f7
  creativeSetId: 7f6117a1-fb7b-4579-868c-118fcca3c55f
  category: jp trial 3-search competitor word
  targetUrl: https://www.brave.com
  geoTarget: JP
  confirmationType: view

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment