Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes purchase intent does not work if Brave is set to JP locale - 1.12.x #6077

Merged
merged 1 commit into from
Jul 15, 2020

Conversation

tmancey
Copy link
Collaborator

@tmancey tmancey commented Jul 14, 2020

Uplift of #6076
Resolves brave/brave-browser#10737

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@tmancey tmancey added this to the 1.12.x - Beta milestone Jul 14, 2020
@tmancey tmancey requested a review from a team July 14, 2020 23:40
@tmancey tmancey self-assigned this Jul 14, 2020
@tmancey tmancey requested a review from moritzhaller July 14, 2020 23:41
Copy link
Contributor

@moritzhaller moritzhaller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kjozwiak
Copy link
Member

test-browser failed on Linux as per https://ci.brave.com/job/pr-brave-browser-issues-10737-1.12.x/1/execution/node/459/log/. However, this is a known intermittent issue and not due to this specific PR.

20:44:32  1 test failed:
20:44:32      RewardsBrowserTest.NotVerifiedWallet (../../brave/components/brave_rewards/browser/test/rewards_browsertest.cc:241)

test-install failed on macOS as per https://ci.brave.com/job/pr-brave-browser-issues-10737-1.12.x/1/execution/node/583/log/. However, this is a known intermittent issue as well.

Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.12.x approved after deliberating with @brave/uplift-approvers. We basically ran out of time to QA this on Nightly before we uplift. However, @moritzhaller mentioned this was tested and is working as expected. QA will verify on the 1.11.x RC3.

@kjozwiak kjozwiak merged commit 94f967e into 1.12.x Jul 15, 2020
@kjozwiak kjozwiak deleted the issues/10737-1.12.x branch July 15, 2020 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants