Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Promotion link #10838

Closed
mandar-brave opened this issue Jul 21, 2020 · 4 comments · Fixed by brave/brave-core#6138
Closed

Promotion link #10838

mandar-brave opened this issue Jul 21, 2020 · 4 comments · Fixed by brave/brave-core#6138
Assignees
@NejcZdovc
Labels
feature/rewards OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude
Milestone
1.13.x - Release #1

Comments

@mandar-brave
Copy link

Promote using existing Rewards space to promote existing ID verified wallet users to subscribe to offers from Uphold.
This is a general placeholder for all promotions from Uphold in Rewards.

@NejcZdovc
@mandar-brave mandar-brave added feature/rewards priority/P3 The next thing for us to work on. It'll ride the trains. OS/Desktop labels Jul 21, 2020
@NejcZdovc NejcZdovc mentioned this issue Jul 21, 2020
Merged
32 tasks
@NejcZdovc NejcZdovc self-assigned this Jul 22, 2020
NejcZdovc added a commit to brave/brave-core that referenced this issue Jul 22, 2020
@NejcZdovc
Adds promotion card
e93cf59 
brave/brave-browser#10838
NejcZdovc added a commit to brave/brave-core that referenced this issue Jul 27, 2020
@NejcZdovc
Adds promotion card
c2d06e3 
brave/brave-browser#10838
@NejcZdovc NejcZdovc added this to the 1.13.x - Nightly milestone Jul 28, 2020
@LaurenWags
Copy link
Member

Marking as QA/Blocked pending answers from https://bravesoftware.slack.com/archives/CB0KCRCQN/p1597406587078700

@mandar-brave
Copy link
Author

@LaurenWags i explained on slack thread; what else do you need from me?
thanks

@LaurenWags
Copy link
Member

Expected text for the promotional card on brave://rewards and what URL it should link to when you click on it. Thanks!

@LaurenWags
Copy link
Member

LaurenWags commented Aug 14, 2020 •
edited by GeetaSarvadnya
Loading

Verified passed with

Brave | 1.13.71 Chromium: 84.0.4147.125 (Official Build) dev (64-bit)
-- | --
Revision | d0784639447f2e10d32ebaf9861092b20cfde286-refs/branch-heads/4147@{#1059}
OS | macOS Version 10.14.6 (Build 18G3020)

Verification passed on

Brave 1.13.71 Chromium: 84.0.4147.125 (Official Build) dev (64-bit)
Revision d0784639447f2e10d32ebaf9861092b20cfde286-refs/branch-heads/4147@{#1059}
OS Ubuntu 18.04 LTS

Verification passed on

Brave | 1.13.72 Chromium: 84.0.4147.125 (Official Build) dev (64-bit)
-- | --
Revision | d0784639447f2e10d32ebaf9861092b20cfde286-refs/branch-heads/4147@{#1059}
OS | Windows 10 OS Version 1903 (Build 18362.1016)

@LaurenWags LaurenWags mentioned this issue Aug 14, 2020
Closed
@GeetaSarvadnya GeetaSarvadnya mentioned this issue Aug 17, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NejcZdovc NejcZdovc

Labels
feature/rewards OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.13.x - Release #1
Development

Successfully merging a pull request may close this issue.

Adds uphold card brave/brave-core
5 participants
@NejcZdovc @LaurenWags @btlechowski @mandar-brave @GeetaSarvadnya