Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds uphold card #6138

Merged
merged 1 commit into from
Jul 28, 2020
Merged

Adds uphold card #6138

merged 1 commit into from
Jul 28, 2020

Conversation

NejcZdovc
Copy link
Contributor

@NejcZdovc NejcZdovc commented Jul 21, 2020

Resolves brave/brave-browser#10838

Submitter Checklist:

Test Plan:

  • enable rewards
  • connect KYC uphold account
  • you should see uphold card on rewards page

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@NejcZdovc NejcZdovc self-assigned this Jul 21, 2020
@NejcZdovc NejcZdovc force-pushed the uphold-card branch 3 times, most recently from 3e5d35b to abb20cb Compare July 21, 2020 19:53
@NejcZdovc NejcZdovc added CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS labels Jul 22, 2020
@NejcZdovc NejcZdovc requested review from a team, emerick and zenparsing and removed request for a team July 22, 2020 09:58
@NejcZdovc NejcZdovc added this to the 1.13.x - Nightly milestone Jul 22, 2020
@NejcZdovc NejcZdovc marked this pull request as ready for review July 22, 2020 09:58
Copy link
Contributor

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@NejcZdovc NejcZdovc merged commit 84e1119 into master Jul 28, 2020
@NejcZdovc NejcZdovc deleted the uphold-card branch July 28, 2020 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-android Do not run CI builds for Android CI/skip-ios Do not run CI builds for iOS feature/rewards
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Promotion link
3 participants