Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Desktop] Wrong code words are shown in View Sync Code after sync creation #10857

Closed
btlechowski opened this issue Jul 22, 2020 · 2 comments · Fixed by brave/brave-core#6182
Closed

Comments

@btlechowski
Copy link

Completely different code words are shown in View Sync Code compared to the ones used to create sync chain.

Steps to Reproduce

  1. Clean install
  2. Open brave://settings/braveSync/setup
  3. Click Start a new sync chain
  4. Click Computer
  5. Copy the code words
  6. Click OK
  7. Click Manage your synced devices
  8. Click View Sync Code

Actual result:

Different Code words are used
sync2_wrong_code_words
Code words used to create sync chain: erode town stool cactus measure setup portion police soldier father hover modify acid coyote lens catch velvet oyster peanut stay fever crater sleep stick
Code words in View Sync Code: adjust hour inside cat barely replace thunder popular text hip yard begin stumble miss retire between square pony vacant fat guide subway ethics isolate

Note: Page reload fixes the issue

Expected result:

Same Code words are used

Reproduces how often:

100% repro rate

Brave version (brave://version info)

Brave 1.12.94 Chromium: 84.0.4147.89 (Official Build) dev (64-bit)
Revision 19abfe7bcba9318a0b2a6bc6634a67fc834aa592-refs/branch-heads/4147@{#852}
OS Ubuntu 18.04 LTS
Brave 1.13.36 Chromium: 84.0.4147.89 (Official Build) nightly (64-bit)
Revision 19abfe7bcba9318a0b2a6bc6634a67fc834aa592-refs/branch-heads/4147@{#852}
OS Ubuntu 18.04 LTS

cc @brave/legacy_qa @jsecretan @rebron @darkdh @AlexeyBarabash @yrliou @petemill

@btlechowski
Copy link
Author

btlechowski commented Jul 22, 2020

Another Test Case - Sync between two devices
Both devices got wrong code words

Steps

  1. Clean install DeviceA and DeviceB
  2. On DeviceA open brave://settings/braveSync/setup
  3. On DeviceA click Start a new sync chain
  4. On DeviceA click Computer
  5. On DeviceA copy the code words
  6. On DeviceA click OK
  7. On DeviceA Compare View Sync Code with copied ones
  8. On DeviceB open brave://settings/braveSync/setup
  9. On DeviceB click I have a sync Code
  10. On DeviceB paste the code words
  11. On DeviceB click Confirm
  12. On DeviceB Compare View Sync Code with copied ones

Results
Code words on both devices are different than the ones used to create sync chain

@btlechowski
Copy link
Author

btlechowski commented Aug 3, 2020

Verification passed on

Brave 1.12.105 Chromium: 84.0.4147.105 (Official Build) (64-bit)
Revision a6b12dfad6663f13a7e16e9a42a6a4975374096b-refs/branch-heads/4147@{#943}
OS Ubuntu 18.04 LTS

Verified test plan from brave/brave-core#6182 (comment).

Copied code words
image
Code words from View Sync Code
image
Code words after sync reset
image
Code words from View Sync Code after sync reset
image

Verified test case from #10857 (comment)
image


Verification passed on


Brave | 1.12.107 Chromium: 84.0.4147.105 (Official Build) (64-bit)
-- | --
Revision | a6b12dfad6663f13a7e16e9a42a6a4975374096b-refs/branch-heads/4147@{#943}
OS | Windows 10 OS Version 1903 (Build 18362.959)

Copied code words
image

Code words from View Sync Code
image

Code words after sync reset
image

Code words from View Sync Code after sync reset
image


Verification PASSED on macOS 10.15.6 x64 using the following build:

Brave | 1.12.108 Chromium: 84.0.4147.105 (Official Build) (64-bit)
-- | --
Revision | a6b12dfad6663f13a7e16e9a42a6a4975374096b-refs/branch-heads/4147@{#943}
OS | macOS Version 10.15.6 (Build 19G73)

Ensured that the STR/Cases outlined via #10857 (comment) worked as expected:

Code via Setup Code under Manage
Screen Shot 2020-08-10 at 8 16 05 PM Screen Shot 2020-08-10 at 8 16 14 PM

Ensured that the STR/Cases outlined via #10857 (comment) worked as expected:

Code via Setup (macOS) Code under Manage (macOS)
Screen Shot 2020-08-10 at 8 22 59 PM Screen Shot 2020-08-10 at 8 23 33 PM
Code under Manage (Win 10 x64)
Annotation 2020-08-10 202631

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment