Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] cross promotional Modal for existing user #10924

Closed
deeppandya opened this issue Jul 26, 2020 · 1 comment · Fixed by brave/brave-core#6212
Closed

[Android] cross promotional Modal for existing user #10924

deeppandya opened this issue Jul 26, 2020 · 1 comment · Fixed by brave/brave-core#6212

Comments

@deeppandya
Copy link

Description

Add cross promotional Modal for existing user.
Related issue for new user : #10571
Related PR : brave/brave-core#6171

Steps to reproduce

  1. Update brave app
  2. Open app on 12th day

Actual result

Expected result

Should show the cross promotional modal

Issue reproduces how often

Issue happens on

  • Current Play Store version?
  • Beta build?

Device details

  • Install type (ARM, x86):
  • Device (Phone, Tablet, Phablet):
  • Android version:

Brave version

Website problems only

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Additional information

@srirambv
Copy link
Contributor

srirambv commented Sep 2, 2020

Verification passed on OnePlus 6T with Android 10 running 1.13.83 x64 build

Verified cross-platform promotional modal is shown 12 days after upgrading from `1.12.113` to `1.13.83`
English French
image image

Verification passed on Samsung Tab A with Android 10 running 1.13.83 x64 build

Verified cross-platform promotional modal is shown 12 days after upgrading from `1.12.113` to `1.13.83`
English German
image image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants