Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Desktop] Caching bug causes user to re-auth twice with Uphold #10936

Closed
mandar-brave opened this issue Jul 27, 2020 · 1 comment · Fixed by brave/brave-core#6235
Closed

[Desktop] Caching bug causes user to re-auth twice with Uphold #10936

mandar-brave opened this issue Jul 27, 2020 · 1 comment · Fixed by brave/brave-core#6235
Assignees
@NejcZdovc
Labels
feature/rewards OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude
Milestone
1.14.x - Release #1

Comments

@mandar-brave
Copy link

If an Uphold token gets invalidated and user tries re-auth before restarting browser via Rewards Panel, the re-auth gives a "Try Again' error - if user tries again, user gets new token.

The Try Again error is a bad UX and needs to be resolved by invalidating cache on re-auth.

cc @NejcZdovc
@mandar-brave mandar-brave added feature/rewards priority/P2 A bad problem. We might uplift this to the next planned release. OS/Desktop labels Jul 27, 2020
@NejcZdovc NejcZdovc self-assigned this Jul 28, 2020
@NejcZdovc NejcZdovc mentioned this issue Jul 28, 2020
Merged
32 tasks
NejcZdovc added a commit to brave/brave-core that referenced this issue Jul 28, 2020
@NejcZdovc
Fixes uphold cache when disconnected
e28a3a9 
Resolves brave/brave-browser#10936
@NejcZdovc NejcZdovc added this to the 1.14.x - Nightly milestone Jul 29, 2020
@LaurenWags LaurenWags mentioned this issue Aug 31, 2020
Closed
@LaurenWags
Copy link
Member

LaurenWags commented Aug 31, 2020 •
edited by btlechowski
Loading

Verified passed with

Brave | 1.14.69 Chromium: 85.0.4183.83 (Official Build) dev (64-bit)
-- | --
Revision | 94abc2237ae0c9a4cb5f035431c8adfb94324633-refs/branch-heads/4183@{#1658}
OS | macOS Version 10.14.6 (Build 18G3020)

Verified test plan from brave/brave-core#6235

  • After disconnecting:

Screen Shot 2020-08-31 at 11 33 33 AM

  • Clicking on Disconnected showed login flow:

Screen Shot 2020-08-31 at 11 33 50 AM

  • After clicking login, received the authorization screen:

Screen Shot 2020-08-31 at 11 34 05 AM

  • Confirmed after re-auth, was connected successfully:

Screen Shot 2020-08-31 at 1 44 56 PM

Verification passed on


Brave | 1.14.69 Chromium: 85.0.4183.83 (Official Build) dev (64-bit)
-- | --
Revision | 94abc2237ae0c9a4cb5f035431c8adfb94324633-refs/branch-heads/4183@{#1658}
OS | Windows 10 OS Version 1903 (Build 18362.1016)

  • After disconnecting:
    image

  • Clicking on Disconnected showed login flow:
    image

  • After clicking login, received the authorization screen:
    image

  • Confirmed after re-auth, was connected successfully:
    image

Verification passed on

Brave 1.14.71 Chromium: 85.0.4183.83 (Official Build) dev (64-bit)
Revision 94abc2237ae0c9a4cb5f035431c8adfb94324633-refs/branch-heads/4183@{#1658}
OS Ubuntu 18.04 LTS

  • After disconnecting:
    image

  • Clicking on Disconnected showed login flow:
    image

  • After clicking login, received the authorization screen:
    image

  • Confirmed after re-auth, was connected successfully:
    image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NejcZdovc NejcZdovc

Labels
feature/rewards OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.14.x - Release #1
Development

Successfully merging a pull request may close this issue.

Fixes uphold cache when disconnected brave/brave-core
5 participants
@NejcZdovc @LaurenWags @btlechowski @mandar-brave @GeetaSarvadnya