Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Desktop] sync button in profile manager #11425

Closed
LaurenWags opened this issue Aug 25, 2020 · 1 comment · Fixed by brave/brave-core#6499
Closed

[Desktop] sync button in profile manager #11425

LaurenWags opened this issue Aug 25, 2020 · 1 comment · Fixed by brave/brave-core#6499

Comments

@LaurenWags
Copy link
Member

LaurenWags commented Aug 25, 2020

Description

In 1.14.x and 1.15.x (so far), there are multiple issues with the profile manager. First one is:

  1. There is a large "Turn on sync" button which should be removed (if you click on it, this causes perf issues, browser freezing, so we should remove the button or address these issues)

Second one was moved to #11444

Steps to Reproduce

  1. Clean profile with 1.14.x or 1.15.x
  2. Create a second profile
  3. Click on one of the profile icons --> See large "Turn on sync" button

Actual result:

Step 3:
Screen Shot 2020-08-25 at 3 09 17 PM
Screen Shot 2020-08-25 at 3 09 00 PM

Expected result:

No sync button on profile manager:
Screen Shot 2020-08-25 at 3 39 19 PM

Reproduces how often:

easily

Brave version (brave://version info)

1.14.63 (Dev)
1.15.6 (Nightly)

Version/Channel Information:

  • Can you reproduce this issue with the current release? 1.12.x C84 no, 1.13.x CR 85.0.4183.69 not atm, but it is currently behind the others in CR version
  • Can you reproduce this issue with the beta channel? yes, 1.14.63 CR 85.0.4183.78
  • Can you reproduce this issue with the nightly channel? yes 1.15.6 CR 85.0.4183.78

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

cc @rebron @mkarolin @Brave-Matt

@rebron rebron added the priority/P2 A bad problem. We might uplift this to the next planned release. label Aug 25, 2020
mkarolin added a commit to brave/brave-core that referenced this issue Aug 25, 2020
@mkarolin mkarolin self-assigned this Aug 25, 2020
@mkarolin mkarolin added this to the 1.15.x - Nightly milestone Aug 26, 2020
@LaurenWags LaurenWags changed the title [Desktop] multiple issues with profile manager [Desktop] sync button in profile manager Aug 26, 2020
@LaurenWags
Copy link
Member Author

LaurenWags commented Sep 3, 2020

Verified passed with

Brave | 1.14.74 Chromium: 85.0.4183.83 (Official Build) dev (64-bit)
-- | --
Revision | 94abc2237ae0c9a4cb5f035431c8adfb94324633-refs/branch-heads/4183@{#1658}
OS | macOS Version 10.14.6 (Build 18G3020)
  • Verified STR from description

Screen Shot 2020-09-03 at 10 17 33 AM


Verification passed on


Brave | 1.14.74 Chromium: 85.0.4183.83 (Official Build) dev (64-bit)
-- | --
Revision | 94abc2237ae0c9a4cb5f035431c8adfb94324633-refs/branch-heads/4183@{#1658}
OS | Windows 10 OS Version 1903 (Build 18362.1016)

  • Verified STR from description

Profile 2:
image

Profile 1:
image


Verification passed on

Brave 1.14.75 Chromium: 85.0.4183.83 (Official Build) dev (64-bit)
Revision 94abc2237ae0c9a4cb5f035431c8adfb94324633-refs/branch-heads/4183@{#1658}
OS Ubuntu 18.04 LTS

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants