[Desktop] google account info showing in profile manager

[LaurenWags]

Test Plan

Specified here: brave/brave-core#6516

Description

Broken out from #11425

In 1.14.x and 1.15.x (so far), there are multiple issues with the profile manager. Second one is:

2. If you are signed into a google account, additional problems occur:

• You get a "Manage your Brave sync chain" option that doesn't take you to sync settings (we probably want to remove this or fix where it leads to)
• You get a "Sign out" option on profile menu (we probably want to remove this since signing into Google shouldn't affect the profile manager)
• Your profile icon, previously a Brave image changes to your google account image (I had to restart to see this, but it did occur - we probably want to fix this as well)

Note - above was only seen when logged into one google account. Should also confirm logging into two google accounts (ex. work and personal) when retesting.

Steps to Reproduce

1. Clean profile with 1.14.x or 1.15.x
2. Create a second profile
3. Click on one of the profile icons --> See large "Turn on sync" button ([Desktop] sync button in profile manager #11425)
4. In one of the windows, sign into mail.google.com
5. Click on one of the profile icons --> see "Manage your Brave sync chain" and "Sign out" options. If your profile icon hasn't changed, restart your browser and it will most likely update to your google account image.

Actual result:

Step 5:

Expected result:

Logging into Google account shouldn't have any affect on profile manager:

Reproduces how often:

easily

Brave version (brave://version info)

1.14.63 (Dev)
1.15.6 (Nightly)

Version/Channel Information:

• Can you reproduce this issue with the current release? 1.12.x C84 no, 1.13.79 CR 85.0.4183.69 not atm, but it is currently behind the others in CR version
• Can you reproduce this issue with the beta channel? yes, 1.14.63 CR 85.0.4183.78
• Can you reproduce this issue with the nightly channel? yes 1.15.6 CR 85.0.4183.78

Other Additional Information:

• Does the issue resolve itself when disabling Brave Shields?
• Does the issue resolve itself when disabling Brave Rewards?
• Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

cc @rebron @mkarolin @Brave-Matt @brave/legacy_qa

[GeetaSarvadnya]

Verification passed on

Brave | 1.14.79 Chromium: 85.0.4183.83 (Official Build) dev (64-bit)
-- | --
Revision | 94abc2237ae0c9a4cb5f035431c8adfb94324633-refs/branch-heads/4183@{#1658}
OS | Windows 10 OS Version 1903 (Build 18362.1016)

1. Verified the test plan from the PR https://github.com/brave/brave-core/pull/6516

Step 2: Confirmed no Accounts in Token Service or Refresh token events

Step 3: Confirmed Allow Google Login for extensions is off by default

Step 3: Confirmed toggling Allow Google Login for extensions prompts for a restart

Step 3: Confirmed Allow Google Login for extensions is on after the restart

Step 4: Able to use Google Keep extension

Step 5: Able to use Google Calendar extension

Step 6: Confirmed profile menu doesn't show any Google sign in data

Step 9: Confirmed after removing site data, disabling Allow Google Login for extensions and relaunching, when attempting to use the Google Keep extension the Sign in button does not work

Also verified the below scenarios:

Scenario 1 - install extension before signing into Google

1. Installed build with fresh profile
2. Navigated to brave://settings/extensions, enabled Allow Google Login for extensions and relaunched
3. Confirmed setting retained after relaunch
4. Navigate to https://chrome.google.com/webstore/detail/google-keep-chrome-extens/lpcaedmchfhocbbapmcbpinfpgnhiddi and install this extension
5. Close Google login page that opens
6. Open a tab and navigate to brave.com
7. Open extension, see Sign in button as below
8. Click on it and login on resulting Google page
9. Confirmed able to login and use extension

• Encountered [Desktop] Follow up of #3650 - Unable to authenticate or use Google Keep extension in Brave #11493
  
  

Scenario 2 - toggle setting multiple times

1. Installed build with fresh profile
2. Navigated to brave://settings/extensions, enabled Allow Google Login for extensions and relaunched
3. Confirmed setting is on
4. Disabled Allow Google Login for extensions and relaunched
5. Confirmed setting is off
6. Enabled Allow Google Login for extensions and relaunched
7. Confirmed setting is on

Scenario 3 - STR from /issues/11444

1. Clean profile
2. Create a second profile
3. In one of the windows, sign into mail.google.com (this is Window A)
4. Click on the profile icon of Window A
5. Confirm you do not see "Manage your Brave sync chain" and "Sign out" options.
6. Close and Relaunch.
7. Click on profile icon of Window A
8. Confirm profile icon has not changed to reflect the google account's image.
9. Click on profile icon of Window B.
10. Confirm you do not see "Manage your Brave sync chain" and "Sign out" options. Confirm profile icon has not changed.

Verification PASSED on macOS 10.15.6 x64 using the following build:

Brave | 1.14.81 Chromium: 85.0.4183.102 (Official Build) (64-bit)
-- | --
Revision | ffe848af6a5df4fa127e2929331116b7f9f1cb30-refs/branch-heads/4183@{#1770}
OS | macOS Version 10.15.6 (Build 19G73)

Ran through the STR/Cases outlined via brave/brave-core#6516 (comment) and ensured the following:

Case 1 - STR/Cases from brave/brave-core/pull/6516 (including extension checks)

• ensured that both Accounts in Token Service & No token in Token Service were blank as per the following:

• ensured that Allow Google login for extensions appears under brave://settings/extensions without any issues
• ensured that clicking on Learn more opens https://github.com/brave/brave-browser/wiki/Allow-Google-login---Third-Parties-and-Extensions
• ensured that enabling Allow Google login for extensions under brave://settings/extensions allows you to use both https://chrome.google.com/webstore/detail/google-keep-chrome-extens/lpcaedmchfhocbbapmcbpinfpgnhiddi and https://chrome.google.com/webstore/detail/google-calendar/gmbgaklkmjakoegficnlkhebmhkjfich
• ensured that disabling Allow Google login for extensions logs the user out of the extensions that are currently using Google Login

Example of Allow Google login for extensions:

Example of Google Calendar and Google Keep being installed:

Google Login Enabled	Google Login Enabled

Google Login Disabled	Google Login Disabled

• ensured that the profile menu didn't display any information regarding Google login as per the following:

Main Profile	Second Profile (Created after enabling setting)

Case 2 - Extensions (GCal & Keep

Ensured that enabling/disabling Allow Google login for extensions via brave://settings/extensions works as expected.

Google Login Enabled	Google Login Enabled

Google Login Disabled	Google Login Disabled

Case 3 - STR/Cases outlined via #11444

• ensured that the profile menu didn't display any information regarding Google login as per the following:

Main Profile	Second Profile (Created after enabling setting)

Verification passed on

Brave	1.14.81 Chromium: 85.0.4183.102 (Official Build) (64-bit)
Revision	ffe848af6a5df4fa127e2929331116b7f9f1cb30-refs/branch-heads/4183@{#1770}
OS	Ubuntu 18.04 LTS

1. Verified the test plan from the PR https://github.com/brave/brave-core/pull/6516

Step 2: Confirmed no Accounts in Token Service or Refresh token events

Step 3: Confirmed Allow Google Login for extensions is off by default

Step 3: Confirmed toggling Allow Google Login for extensions prompts for a restart

Step 3: Confirmed Allow Google Login for extensions is on after the restart

Step 4: Able to use Google Keep extension

Step 5: Able to use Google Calendar extension

Step 6: Confirmed profile menu doesn't show any Google sign in data

Step 9: Confirmed after removing site data, disabling Allow Google Login for extensions and relaunching, when attempting to use the Google Keep extension the Sign in button does not work

Also verified the below scenarios:

Scenario 1 - install extension before signing into Google

1. Installed build with fresh profile
2. Navigated to brave://settings/extensions, enabled Allow Google Login for extensions and relaunched
3. Confirmed setting retained after relaunch
4. Navigate to https://chrome.google.com/webstore/detail/google-keep-chrome-extens/lpcaedmchfhocbbapmcbpinfpgnhiddi and install this extension
5. Close Google login page that opens
6. Open a tab and navigate to brave.com
7. Open extension, see Sign in button as below
8. Click on it and login on resulting Google page
9. Confirmed able to login and use extension

Scenario 2 - toggle setting multiple times

1. Installed build with fresh profile
2. Navigated to brave://settings/extensions, enabled Allow Google Login for extensions and relaunched
3. Confirmed setting is on
4. Disabled Allow Google Login for extensions and relaunched
5. Confirmed setting is off
6. Enabled Allow Google Login for extensions and relaunched
7. Confirmed setting is on

Scenario 3 - STR from /issues/11444

1. Clean profile
2. Create a second profile
3. In one of the windows, sign into mail.google.com (this is Window A)
4. Click on the profile icon of Window A
5. Confirm you do not see "Manage your Brave sync chain" and "Sign out" options.
6. Close and Relaunch.
7. Click on profile icon of Window A
8. Confirm profile icon has not changed to reflect the google account's image.
9. Click on profile icon of Window B.
10. Confirm you do not see "Manage your Brave sync chain" and "Sign out" options. Confirm profile icon has not changed.