Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #11444: Google accounts should not show in the profile menu (uplift to 1.14.x) #6552

Merged
merged 1 commit into from
Sep 1, 2020

Conversation

jumde
Copy link
Contributor

@jumde jumde commented Aug 31, 2020

Uplift of #6516
Resolves brave/brave-browser#11444

Approved, please ensure that before merging:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

Fix #11444: Google accounts should not show in the profile menu
@jumde jumde requested a review from bridiver as a code owner August 31, 2020 21:05
@jumde jumde requested a review from a team August 31, 2020 21:07
@kjozwiak
Copy link
Member

kjozwiak commented Sep 1, 2020

Restarting macOS via https://ci.brave.com/job/brave-core-build-pr-macos/job/PR-6552/2/ as it seems like CI timed out during the build phase and never completed as per https://ci.brave.com/job/pr-brave-browser-profile_manager_1.14.x-macos/1/execution/node/174/log/.

17:43:34  [23905/43062] CXX obj/mojo/public/mojom/base/base_blink/memory_allocator_dump_cross_process_uid.mojom-blink.o
21:13:39  Could not connect to mac-mini2-ky to send interrupt signal to process

Restarting Win x64 via https://ci.brave.com/job/brave-core-build-pr-windows/job/PR-6552/2/ as test-install failed as per https://ci.brave.com/job/pr-brave-browser-profile_manager_1.14.x-windows/1/execution/node/240/log/. Usually we merge even though test-install failed but because macOS was restarted, might as well restart Win x64 as they'll be completed around the same time.

@kjozwiak
Copy link
Member

kjozwiak commented Sep 1, 2020

test-browser failed on macOS as per https://ci.brave.com/job/pr-brave-browser-profile_manager_1.14.x-macos/3/execution/node/221/log/. However, these are known intermittent failures and don't block uplift.

00:07:48  2 tests failed:
00:07:48      RewardsContributionBrowserTest.SplitProcessOneTimeTip (../../brave/components/brave_rewards/browser/test/rewards_contribution_browsertest.cc:859)
00:07:48      RewardsContributionBrowserTest.SplitProcessorAutoContribution 

Copy link
Member

@LaurenWags LaurenWags left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift to 1.14.x has been approved after deliberating with @brave/uplift-approvers. QA has verified this PR on Nightly as per #6516 (comment).

@LaurenWags LaurenWags merged commit 3877270 into 1.14.x Sep 1, 2020
@LaurenWags LaurenWags deleted the profile_manager_1.14.x branch September 1, 2020 14:34
@LaurenWags LaurenWags added this to the 1.14.x - Beta milestone Sep 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants