Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Android] location message says "Chromium" instead of "Brave" #11656

Closed
LaurenWags opened this issue Sep 10, 2020 · 3 comments · Fixed by brave/brave-core#6619
Closed

[Android] location message says "Chromium" instead of "Brave" #11656

LaurenWags opened this issue Sep 10, 2020 · 3 comments · Fixed by brave/brave-core#6619
Labels
branding OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA Pass - Android Tab QA Pass - Android x86 QA/Yes regression release-notes/include
Milestone
1.13.x - Release #4

Comments

@LaurenWags
Copy link
Member

Description

In 1.12.113 (C84) the message asking for location said "Brave needs access...".

In 1.13.83 and 1.13.86 (C85), the message now says "Chromium needs access..."

Steps to reproduce

  1. Install 1.13.x version of Brave (1.13.83 or 1.13.86 will work)
  2. Tap on URL bar, can keep Google as the SE
  3. Enter a search term that would prompt a location

Actual result

1.13.x versions show message with "Chromium"
Android1 13 x

Expected result

Should be like 1.12.x version that says "Brave"
Android1 12 x

Issue reproduces how often

easily

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version? yes
  • Can you reproduce this issue with the current Play Store Beta version? yes
  • Can you reproduce this issue with the current Play Store Nightly version? yes

Device details

  • Install type (ARM, x86): all
  • Device type (Phone, Tablet, Phablet): all
  • Android version: all

Brave version

1.13.83, 1.13.86

Website problems only

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Additional information

cc @srirambv
@LaurenWags LaurenWags added QA/Yes regression branding OS/Android Fixes related to Android browser functionality labels Sep 10, 2020
@btlechowski
Copy link

btlechowski commented Sep 10, 2020 •
edited
Loading

Reproducible on Tablet.

Brave v1.13.86 on Samsung Galaxy Tab S5e (Android 9.0)

Searched for McDonalds

Screenshot_20200910-203224_Brave

@kjozwiak
Copy link
Member

Reproduced the issue on Samsung Galaxy S10+ running Android 10 using https://github.com/brave/brave-browser/releases/tag/v1.13.86.

  • launched 1.13.86 CR: 85.0.4183.102
  • kept Google as the default SE via onboarding
  • tapped on the URL and used pizza as the search term

mkarolin added a commit to brave/brave-core that referenced this issue Sep 10, 2020
@mkarolin
Restores branding path config arg for Android.
68d3d1d 
This arg is needed on Android so that the correct .grd is used (e.g
brave_strings.grd instead of chromium_strings.grd, see
chrome-app-BUILD.gn.patch).

Fixes brave/brave-browser#11656
@mkarolin mkarolin mentioned this issue Sep 10, 2020
Merged
32 tasks
mkarolin added a commit that referenced this issue Sep 10, 2020
@mkarolin
Restores branding path config arg for Android.
32eb038 
This arg is needed on Android so that the correct .grd is used (e.g
brave_strings.grd instead of chromium_strings.grd, see
chrome-app-BUILD.gn.patch).

Fixes #11656
This was referenced Sep 10, 2020
Merged
Merged
Merged
This was referenced Sep 10, 2020
Closed
Closed
Closed
@kjozwiak kjozwiak added this to the 1.13.x - Release #4 milestone Sep 10, 2020
@kjozwiak kjozwiak mentioned this issue Sep 11, 2020
Closed
@srirambv
Copy link
Contributor

srirambv commented Sep 11, 2020 •
edited by LaurenWags
Loading

Verification passed on OnePlus 6T with Android 10 running 1.13.87 x64 build

  • Verified no Chromium branding is used on location access message
    image

Verification passed on Samsung Tab A with Android 10 running 1.13.87 x64 build

  • Verified no Chromium branding is used on location access message
    image

Verification passed on Asus Zenfone (x86) with Android 6 running 1.13.87 BraveModernx86.apk

  • Verified no Chromium branding is used on location access message
    Android-11656

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
branding OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA Pass - Android Tab QA Pass - Android x86 QA/Yes regression release-notes/include
Projects
None yet
Milestone
1.13.x - Release #4
Development

Successfully merging a pull request may close this issue.

Restores branding path config arg for Android. brave/brave-core
4 participants
@kjozwiak @srirambv @LaurenWags @btlechowski