Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restores branding path config arg for Android (1.14.x). #6621

Merged
merged 1 commit into from
Sep 10, 2020

Conversation

mkarolin
Copy link
Collaborator

Fixes brave/brave-browser#11656
Uplift from #6619.

Submitter Checklist:

Test Plan:

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

Restores branding path config arg for Android.
@mkarolin mkarolin added CI/skip-linux CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS labels Sep 10, 2020
@mkarolin mkarolin added this to the 1.14.x - Release milestone Sep 10, 2020
@mkarolin mkarolin requested a review from a team September 10, 2020 21:08
@mkarolin mkarolin self-assigned this Sep 10, 2020
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.14.x approved after deliberating with @brave/uplift-approvers. @SergeyZhukovsky verified that the fix was working with a PR build on an emulated instance. QA will verify once we get the RC's.

@kjozwiak kjozwiak merged commit 1e3a65a into 1.14.x Sep 10, 2020
@kjozwiak kjozwiak deleted the maxk-fix-android-branding-1.14.x branch September 10, 2020 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants