Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Greaselion content script sometimes doesn't load until restarting browser #11837

Closed
emerick opened this issue Sep 24, 2020 · 2 comments · Fixed by brave/brave-core#6698
Closed

Comments

@emerick
Copy link
Contributor

emerick commented Sep 24, 2020

Create a Greaselion.json file like the following and a simple script that just prints Hello, world! to the console:

  {
    "urls": [
      "https://twitter.com/*",
      "https://*.twitter.com/*"
    ],
    "scripts": [
      "myscript.js"
    ]
  }

If you launch the browser clean (with no open pages) and then navigate to https://twitter.com/emerick, once in a while the content script will not load at all. This occurs maybe 1 in 10 or 1 in 20 times. In addition, no amount of refreshing the page or creating new tabs will cause the content script to load; the only recourse I've found is to restart the browser. I don't see any relevant error messages in the log or console when this occurs, unfortunately.

@emerick
Copy link
Contributor Author

emerick commented Sep 24, 2020

Actually, I can make this happen every time by adding some additional entries to Greaselion.json. I added 10 just now and it occurs every time.

@LaurenWags
Copy link
Member

Per internal discussions, this issue should be tested when Twitter tipping with Greaselion lands (projected to be 1.17.x). As such, I have logged a follow up issue (#11998) for that milestone and will be marking this one as QA/No. Please adjust if needed.

@LaurenWags LaurenWags added QA/No and removed QA/Yes labels Oct 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants