Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle pending updates properly in Greaselion #6698

Merged
merged 1 commit into from
Sep 25, 2020

Conversation

emerick
Copy link
Contributor

@emerick emerick commented Sep 24, 2020

Resolves brave/brave-browser#11837

Submitter Checklist:

Test Plan:

Create a Greaselion.json file like this:

[
  {
    "urls": [
      "https://twitter.com/*",
      "https://*.twitter.com/*"
    ],
    "scripts": [
      "scripts/brave_rewards/publisher/twitter/twitter.bundle.js"
    ],
    "preconditions": {
      "twitter-tips-enabled": true
    }
  }
]
  1. Launch browser with a clean profile
  2. Enable Rewards
  3. Enable Twitter tipping in Rewards settings
  4. Relaunch browser
  5. Visit site that matches Greaselion rule with precondition
  6. Ensure that Greaselion script runs as expected

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Greaselion content script sometimes doesn't load until restarting browser
3 participants