Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tear off tab doesn't show shields until URL bar is selected #1276

Closed
srirambv opened this issue Sep 26, 2018 · 3 comments · Fixed by brave/brave-core#587
Closed

Tear off tab doesn't show shields until URL bar is selected #1276

srirambv opened this issue Sep 26, 2018 · 3 comments · Fixed by brave/brave-core#587
Labels
feature/shields The overall Shields feature in Brave. feature/tear-off-tabs QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes
Milestone
0.55.x - Release ...

Comments

@srirambv
Copy link
Contributor

Description

Tear off tab doesn't show shields until URL bar is selected

Steps to Reproduce

  1. Launch a clean profile
  2. Open a new tab and visit a site
  3. Open second tab and visit another site
  4. Tear off tab from step 3 to a new window, shields is not visible
  5. Click on URL bar on tear off window, shields is shown
    Note: Repeat the above steps with chrome:// tab in step 2 doesn't reproduce the issue

Actual result:

missing shields

Expected result:

Shields should be shown for all tabs even if its of a tab thats dragged into a new window

Reproduces how often:

100%

Brave version (chrome://version info)

Brave 0.55.2 Chromium: 70.0.3538.22 (Official Build) (64-bit)
Revision ac9418ba9c3bd7f6baaffa0b055dfe147e0f8364-refs/branch-heads/3538@{#468}
OS All

Reproducible on current release:

N/A

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields?
  • Is the issue reproducible on the latest version of Chrome?

Additional Information

@bbondy reproduced it on macOS
@srirambv srirambv added this to the Releasable builds 0.55.x milestone Sep 26, 2018
@hferreiro hferreiro mentioned this issue Oct 4, 2018
Closed
11 tasks
bbondy pushed a commit to brave/brave-core that referenced this issue Oct 4, 2018
@hferreiro @bbondy
Implement BraveLocationBarView::ChildVisibilityChanged()
afb17e5 
The `BraveActionsContainer` was not being shown when tearing off a tab
into a new window. This was due to `BraveActionsContainer::Update()` not
forcing a `Layout()` in `BraveLocationBarView`. This is now done by
implementing the aforementioned callback.

Fixes brave/brave-browser#1276.
hferreiro added a commit to brave/brave-core that referenced this issue Oct 9, 2018
@hferreiro
Forward preferred size changes from BraveActionsContainer
c0ab2fd 
When a `BraveAction` is added, the size change isn't properly notified
to `BraveLocationBarView`. This commit implements
`ChildPreferredSizeChanged()` in both `BraveActionsContainer` and
`BraveLocationBarView`, and makes sure the action's preferred size is
set after calling `AddChildView()`.

Fixes brave/brave-browser#1276
@hferreiro hferreiro mentioned this issue Oct 9, 2018
Merged
17 tasks
@bbondy bbondy added the QA/Yes label Oct 10, 2018
@srirambv
Copy link
Contributor Author

srirambv commented Oct 11, 2018 •
edited by LaurenWags
Loading

Verification Passed on

Brave 0.55.12 Chromium: 70.0.3538.45 (Official Build) beta (64-bit)
Revision cbdc32e4334458954e9def214d7e5fa1ca1960eb-refs/branch-heads/3538@{#830}
OS Linux

1276

Verification passed on

Brave 0.55.13 Chromium: 70.0.3538.54 (Official Build) beta (64-bit)
Revision 4f8e578b6680574714e9ed3bb9f02922b4dde40d-refs/branch-heads/3538@{#937}
OS Windows 7

image

Verified passed with

Brave 0.55.13 Chromium: 70.0.3538.54 (Official Build) beta(64-bit)
Revision 4f8e578b6680574714e9ed3bb9f02922b4dde40d-refs/branch-heads/3538@{#937}
OS Mac OS X

screen shot 2018-10-13 at 5 37 00 pm

@btlechowski btlechowski mentioned this issue Oct 11, 2018
Closed
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Oct 12, 2018 •
edited
Loading

On windows 10 issue is still not fixed, issue is reproducible only when the window is in Restore mode. Issue is not reproducible when the window is in maximize mode.

restore mode

@GeetaSarvadnya
Copy link

Issue is fixed and working fine on 0.55.13.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature/shields The overall Shields feature in Brave. feature/tear-off-tabs QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes
Projects
None yet
Milestone
0.55.x - Release (Release Channel)
7 participants
@bbondy @hferreiro @kjozwiak @srirambv @LaurenWags @btlechowski @GeetaSarvadnya