Implement BraveLocationBarView::ChildVisibilityChanged()

[hferreiro]

The BraveActionsContainer was not being shown when tearing off a tab
into a new window. This was due to BraveActionsContainer::Update() not
forcing a Layout() in BraveLocationBarView. This is now done by
implementing the aforementioned callback.

Fixes brave/brave-browser#1276.

• Submitted a ticket for my issue if one did not already exist.

• Used Github auto-closing keywords in the commit message.

• Added/updated tests for this change (for new code or code which already has tests).

• Ran git rebase -i to squash commits (if needed).

• Tagged reviewers and labelled the pull request as needed.

• Request a security/privacy review as needed.

• Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone

• New files have MPL-2.0 license header.

• Request a security/privacy review as needed.

• Adequate test coverage exists to prevent regressions

• Verify test plan is specified in PR before merging to source

[simonhong]

LGTM.

I think this approach seems fine.

[bbondy]

Can we call the base class impl as well here in case the base class ever adds something useful inside here and we don't want to miss it.

[simonhong]

@bbondy It calls base class Layout() methods as well.
Ah, I think you mean calling LocationBarView::ChildVisibilityChanged() like below. I think it would be good for future.

void BraveLocationBarView::ChildVisibilityChanged(views::View* child) {
  LocationBarView::ChildVisibilityChanged(child);

  if (child == brave_actions_)
    Layout();
}

[bbondy]

I added a patch for calling the base class, but this PR doesn't fully fix the problem.
Here's how it looks when you tear off:

Some padding goes away and it causes the count to be cut off.

[simonhong]

I think we need some refactoring in this area.
For now, actions status are monitored by BraveActionsContainer and state update is done there.
With current implementation, this status update should be propagated to location bar or toolbar because this container view's bounds/visibility changing would affect their(toolbar/locaitonbar) layout.
So, I think whenever action's state is changed, this container re-layout should be triggered from location bar. WDYT? @petemill @hferreiro

[bbondy]

I think this is a dupe and outdated PR, closing.