-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Youtube video publisher is not added to auto-contribute when video ID contains an underscore #1277
Milestone
Comments
jasonrsadler
changed the title
Youtube video publisher is not added to auto-contribute is video ID contains an underscore
Youtube video publisher is not added to auto-contribute when video ID contains an underscore
Sep 26, 2018
jasonrsadler
pushed a commit
to brave-intl/bat-native-ledger
that referenced
this issue
Sep 26, 2018
jasonrsadler
pushed a commit
to brave-intl/bat-native-ledger
that referenced
this issue
Sep 26, 2018
linting
jasonrsadler
pushed a commit
to brave-intl/bat-native-ledger
that referenced
this issue
Sep 26, 2018
linting Correcting build (initialization order)
jasonrsadler
pushed a commit
to brave-intl/bat-native-ledger
that referenced
this issue
Sep 26, 2018
linting Correcting build (initialization order) linting
jasonrsadler
pushed a commit
to brave-intl/bat-native-ledger
that referenced
this issue
Sep 26, 2018
jasonrsadler
pushed a commit
to brave-intl/bat-native-ledger
that referenced
this issue
Sep 26, 2018
linting Correcting build (initialization order) linting
11 tasks
Verification passed on
Checked all scenarios from brave/brave-core#522 Verification Passed on
Verified passed with
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
When viewing a youtube video, an interval query is sent to get information about viewing times, channel, media ID, etc.
When adding to ledger, the publisher ID is split from the video ID with an underscore delimiter. However, IDs can contain an underscore and will cause 404s when trying to query for publisher.
If video ID begins with an underscore, we will have an empty mediaID, DCHECK will fail, and Brave will crash in debug mode.
Steps to Reproduce
Result: Brave will fail DCHECK and crash in debug mode
Result: Youtube frontend proxy returns 404s in terminal and publisher is not added to autocontribute
Expected result:
Publishers should be added to ledger. Brave should not crash.
Reproduces how often:
100% not added to autocontribute when video id contains an underscore.
100% crashes in debug when video id begins with underscore
Brave version (chrome://version info)
Reproducible on current release:
Untested
Website problems only:
Additional Information
Video IDs will need to be split properly with
[-_0-9A-Za-z]{11}
as a mandatory constraint as the first part.The text was updated successfully, but these errors were encountered: