Skip to content
This repository has been archived by the owner on Dec 12, 2018. It is now read-only.

Youtube and Twitch videos now provide more accurate times than before #114

Merged
merged 3 commits into from
Oct 2, 2018

Conversation

jasonrsadler
Copy link
Contributor

@jasonrsadler jasonrsadler commented Sep 26, 2018

Addresses brave/brave-browser#971

See brave/brave-core#522 for test plan

@jasonrsadler jasonrsadler self-assigned this Sep 26, 2018
@jasonrsadler jasonrsadler force-pushed the feature/fine_tune_time branch 2 times, most recently from 1982edf to 41392c8 Compare September 26, 2018 17:08
@jasonrsadler jasonrsadler changed the title Feature/fine tune time Youtube and Sep 26, 2018
@jasonrsadler jasonrsadler changed the title Youtube and Youtube and Twitch videos now provide more accurate times than before Sep 26, 2018
src/bat_get_media.cc Outdated Show resolved Hide resolved
@jasonrsadler jasonrsadler force-pushed the feature/fine_tune_time branch 4 times, most recently from b76a057 to 8654412 Compare September 26, 2018 22:16
@jasonrsadler jasonrsadler requested a review from ryanml September 26, 2018 22:17
ryanml
ryanml previously approved these changes Sep 26, 2018
Copy link
Contributor

@ryanml ryanml left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

Jason Sadler added 3 commits September 28, 2018 12:08
linting

Correcting build (initialization order)

linting
Reverted fix addressed in another PR.

linting

Updated media ID split to check for delimiter existence
Copy link
Contributor

@NejcZdovc NejcZdovc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TW is still a little bit off especially for streams and vod's that have some buffer problems

@NejcZdovc NejcZdovc merged commit 283fed2 into master Oct 2, 2018
@jasonrsadler jasonrsadler deleted the feature/fine_tune_time branch October 3, 2018 13:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants