This repository has been archived by the owner on Dec 12, 2018. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 8
Youtube and Twitch videos now provide more accurate times than before #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonrsadler
force-pushed
the
feature/fine_tune_time
branch
2 times, most recently
from
September 26, 2018 17:08
1982edf
to
41392c8
Compare
jasonrsadler
changed the title
Youtube and
Youtube and Twitch videos now provide more accurate times than before
Sep 26, 2018
ryanml
reviewed
Sep 26, 2018
ryanml
reviewed
Sep 26, 2018
jasonrsadler
force-pushed
the
feature/fine_tune_time
branch
4 times, most recently
from
September 26, 2018 22:16
b76a057
to
8654412
Compare
ryanml
previously approved these changes
Sep 26, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++
linting Correcting build (initialization order) linting
Reverted fix addressed in another PR. linting Updated media ID split to check for delimiter existence
jasonrsadler
force-pushed
the
feature/fine_tune_time
branch
from
September 28, 2018 16:12
8654412
to
22b0856
Compare
NejcZdovc
reviewed
Sep 28, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TW is still a little bit off especially for streams and vod's that have some buffer problems
NejcZdovc
added
pr/work-in-progress
and removed
PR/Pending Review
pr/work-in-progress
labels
Oct 1, 2018
NejcZdovc
approved these changes
Oct 2, 2018
This was referenced Oct 3, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses brave/brave-browser#971
See brave/brave-core#522 for test plan