Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fine tune time recording #971

Closed
NejcZdovc opened this issue Sep 5, 2018 · 1 comment · Fixed by brave/brave-core#522
Closed

Fine tune time recording #971

NejcZdovc opened this issue Sep 5, 2018 · 1 comment · Fixed by brave/brave-core#522
Assignees
@jasonrsadler
Labels
feature/rewards QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes
Milestone
0.55.x - Release ...

Comments

@NejcZdovc
Copy link
Contributor

Play with youtube and twitch and make sure that time is recorded correctly
@NejcZdovc NejcZdovc added this to the Releasable builds 0.55.x milestone Sep 5, 2018
jasonrsadler pushed a commit to brave-intl/bat-native-ledger that referenced this issue Sep 25, 2018
Fixes brave/brave-browser#971. Fixed youtube time recording truncations
b4c8691
jasonrsadler pushed a commit to brave-intl/bat-native-ledger that referenced this issue Sep 26, 2018
Fixes brave/brave-browser#971. Fixed youtube time recording truncations
0ac4ce5
@jasonrsadler jasonrsadler mentioned this issue Sep 26, 2018
Merged
jasonrsadler pushed a commit to brave-intl/bat-native-ledger that referenced this issue Sep 26, 2018
Fixes brave/brave-browser#971. Fine tuning Twitch time.
41392c8
jasonrsadler pushed a commit to brave-intl/bat-native-ledger that referenced this issue Sep 26, 2018
Fixes brave/brave-browser#971. Fine tuning Twitch time.
4d8ddf4 
Reverted fix addressed in another PR.
jasonrsadler pushed a commit to brave-intl/bat-native-ledger that referenced this issue Sep 26, 2018
Fixes brave/brave-browser#971. Fine tuning Twitch time.
4cc3a0c 
Reverted fix addressed in another PR.

linting
jasonrsadler pushed a commit to brave-intl/bat-native-ledger that referenced this issue Sep 26, 2018
Fixes brave/brave-browser#971. Fixed youtube time recording truncations
745ddbb
jasonrsadler pushed a commit to brave-intl/bat-native-ledger that referenced this issue Sep 26, 2018
Fixes brave/brave-browser#971. Fine tuning Twitch time.
b76a057 
Reverted fix addressed in another PR.

linting
jasonrsadler pushed a commit to brave-intl/bat-native-ledger that referenced this issue Sep 26, 2018
Fixes brave/brave-browser#971. Fine tuning Twitch time.
8654412 
Reverted fix addressed in another PR.

linting

Updated media ID split to check for delimiter existence
jasonrsadler pushed a commit to brave-intl/bat-native-ledger that referenced this issue Sep 28, 2018
Fixes brave/brave-browser#971. Fine tuning Twitch time.
22b0856 
Reverted fix addressed in another PR.

linting

Updated media ID split to check for delimiter existence
@jasonrsadler jasonrsadler mentioned this issue Oct 2, 2018
Merged
11 tasks
@NejcZdovc NejcZdovc reopened this Oct 2, 2018
@srirambv
Copy link
Contributor

srirambv commented Oct 9, 2018 •
edited by LaurenWags
Loading

Verification Passed on

Brave 0.55.11 Chromium: 70.0.3538.35 (Official Build) beta (64-bit)
Revision 28dcb499844fa40c28d5f62e337876cb936f79f5-refs/branch-heads/3538@{#678}
OS Linux
  • Verified all scenarios from test plan and calculations looked correct

Verification passed on

Brave 0.55.11 Chromium: 70.0.3538.35 (Official Build) beta (64-bit)
Revision 28dcb499844fa40c28d5f62e337876cb936f79f5-refs/branch-heads/3538@{#678}
OS Windows 7

Checked all scenarios from brave/brave-core#522. Had to check publisher_info_db for the needed info.

Verified passed with

Brave 0.55.12 Chromium: 70.0.3538.45 (Official Build) beta(64-bit)
Revision cbdc32e4334458954e9def214d7e5fa1ca1960eb-refs/branch-heads/3538@{#830}
OS Mac OS X
  • Verified all scenarios in test plan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jasonrsadler jasonrsadler

Labels
feature/rewards QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes
Projects
None yet
Milestone
0.55.x - Release (Release Channel)
Development

Successfully merging a pull request may close this issue.

Youtube and Twitch videos now provide more accurate times than before
5 participants
@NejcZdovc @srirambv @jasonrsadler @LaurenWags @btlechowski