Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import promoCode from browser-laptop when upgrading to brave-core #1294

Closed
bsclifton opened this issue Sep 26, 2018 · 1 comment · Fixed by brave/brave-core#935
Closed

Import promoCode from browser-laptop when upgrading to brave-core #1294

bsclifton opened this issue Sep 26, 2018 · 1 comment · Fixed by brave/brave-core#935
Assignees
@bsclifton
Labels
feature/importer OS/macOS OS/Windows QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/exclude
Milestone
0.57.x - Release ...

Comments

@bsclifton
Copy link
Member

bsclifton commented Sep 26, 2018 •
edited
Loading

Test plan

See brave/brave-core#935

Description

With brave/brave-core#428, the referral program was implemented on brave-core. As we move towards 1.0, we need to consider what happens when users are using the Muon based product (browser-laptop) and then upgrade

Steps to reproduce

  1. Install the Muon based browser from a referral link (installer name has referral code embedded)
  2. Verify in the session-store-1 that promoCode and download_id are set
  3. (not implemented) check for updates and user is prompted to upgrade to brave-core
  4. brave-core is installed; profile should be imported. promoCode and download_id need to be imported too and put into local_state
@bsclifton bsclifton added this to the 1.x Backlog milestone Sep 26, 2018
@bsclifton bsclifton mentioned this issue Sep 26, 2018
Merged
11 tasks
@srirambv srirambv mentioned this issue Sep 26, 2018
Closed
7 tasks
@bsclifton bsclifton modified the milestones: 1.x Backlog, 1.0 (0.56.x) Sep 27, 2018
@garrettr garrettr mentioned this issue Oct 16, 2018
Closed
@garrettr garrettr self-assigned this Oct 16, 2018
@rebron rebron modified the milestones: 1.0, Muon => Brave Core migration Oct 16, 2018
@bsclifton bsclifton mentioned this issue Oct 17, 2018
Closed
@bbondy bbondy removed this from the Muon => Brave Core migration milestone Oct 30, 2018
@bbondy bbondy added this to the 1.x Backlog milestone Nov 5, 2018
@bsclifton bsclifton modified the milestones: 1.x Backlog, 0.56.x - Release Hotfix 1 Nov 6, 2018
@bsclifton bsclifton assigned bsclifton and unassigned garrettr Nov 13, 2018
@bsclifton bsclifton mentioned this issue Nov 20, 2018
Merged
18 tasks
bsclifton added a commit to brave/brave-core that referenced this issue Nov 21, 2018
@bsclifton
Read referral related values from session-store-1 during import (if t…
1b1b5ff 
…hey are available) and set corresponding values in brave-core.

Fixes brave/brave-browser#1884
Fixes brave/brave-browser#1294
bsclifton added a commit to brave/brave-core that referenced this issue Nov 28, 2018
@bsclifton
Read referral related values from session-store-1 during import (if t…
9a5229e 
…hey are available) and set corresponding values in brave-core.

Fixes brave/brave-browser#1884
Fixes brave/brave-browser#1294
@btlechowski
Copy link

btlechowski commented Dec 4, 2018 •
edited by LaurenWags
Loading

Verification Passed on

Brave 0.57.12 Chromium: 71.0.3578.75 (Official Build) (64-bit)
Revision 06ef00b5279f93f8e0c1e73acedd49d7dcc09767-refs/branch-heads/3578@{#836}
OS Windows 7 x64

Issue found: #2344

Verified passed with

Brave 0.57.12 Chromium: 71.0.3578.75 (Official Build) (64-bit)
Revision 06ef00b5279f93f8e0c1e73acedd49d7dcc09767-refs/branch-heads/3578@{#836}
OS Mac OS X

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bsclifton bsclifton

Labels
feature/importer OS/macOS OS/Windows QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/exclude
Projects
None yet
Milestone
0.57.x - Release (Release Channel)
Development

Successfully merging a pull request may close this issue.

Import promo code from Muon (if present) brave/brave-core
7 participants
@garrettr @bbondy @bsclifton @rebron @srirambv @LaurenWags @btlechowski