promo code is not imported from browser laptop

[btlechowski]

Steps to Reproduce

promoCode is not migrated

1. Install promo version of b-l (I used BraveSetup-x64-KAM253.exe)
2. Quit Muon browser after 5 minutes.
3. Make sure that Muon contains promo code in session-store-1:
4. Download b-c which supports migration(I used 0.57.12) and install it
5. Close b-c and delete user profile (AppData\Local\BraveSoftware\Brave-Browser\)
6. Launch b-c with flag: --upgrade-from-muon
7. Check Local State json file in b-c ``AppData\Local\BraveSoftware\Brave-Browser` for:

"promo_code"

Note: also fails when manually importing Stats from Brave (old)
Note:
referralDownloadId is imported to download_id
weekOfInstallation is imported to week_of_installation
Note: also fails with code BAR248

Actual result:

promo code is not imported

Expected result:

promo code is imported

Reproduces how often:

always

Brave version (brave://version info)

Brave	0.57.12 Chromium: 71.0.3578.75 (Official Build) (64-bit)
Revision	06ef00b5279f93f8e0c1e73acedd49d7dcc09767-refs/branch-heads/3578@{#836}
OS	Windows 7x64

Reproduced on Mac OS by @LaurenWags. Brave 0.57.12.

cc @bsclifton @kjozwiak

[btlechowski]

I got this when using BAR248 in Muon.

"promoCode":"none","referralPromoCode":"BAR248"

https://github.com/brave/brave-core/blob/9a5229e430fa81a1882b584b1bd8f81165c36903/utility/importer/brave_importer.cc#L638

if (!TryFindStringKey(updates, "promoCode", referral.promo_code)) {

[LaurenWags]

Reproduced on macOS

Brave	0.57.12 Chromium: 71.0.3578.75 (Official Build) (64-bit)
Revision	06ef00b5279f93f8e0c1e73acedd49d7dcc09767-refs/branch-heads/3578@{#836}
OS	Mac OS X

Used STR from description (except used .pkg file for macOS). Here is a comparison of session-store-1 and local_state files:

[LaurenWags]

Verified passed with

Brave	0.57.16 Chromium: 71.0.3578.80 (Official Build) (64-bit)
Revision	2ac50e7249fbd55e6f517a28131605c9fb9fe897-refs/branch-heads/3578@{#860}
OS	Mac OS X

• Verified STR from description

Verification Passed on

Brave	0.57.16 Chromium: 71.0.3578.80 (Official Build) (64-bit)
Revision	2ac50e7249fbd55e6f517a28131605c9fb9fe897-refs/branch-heads/3578@{#860}
OS	Windows 7

Verified STR from description