Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Brave Today intro card should dismiss #12960

Closed
petemill opened this issue Dec 1, 2020 · 2 comments · Fixed by brave/brave-core#7111
Closed

Brave Today intro card should dismiss #12960

petemill opened this issue Dec 1, 2020 · 2 comments · Fixed by brave/brave-core#7111
Assignees
@petemill
Labels
OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.19.x - Release

Comments

@petemill
Copy link
Member

petemill commented Dec 1, 2020

Test plan

  1. View Brave Today
  2. Ensure Intro card is on screen for at least 4 seconds
    -> Observe Intro card stays visible
  3. View Brave Today on another tab (or refresh current tab)
    -> Observe Intro card is not visible
@petemill petemill self-assigned this Dec 1, 2020
@petemill petemill added this to the 1.19.x - Nightly milestone Dec 1, 2020
@petemill petemill mentioned this issue Dec 1, 2020
Merged
33 tasks
@petemill
Copy link
Member Author

petemill commented Dec 1, 2020

Closed by brave/brave-core#7111

@petemill petemill closed this as completed Dec 1, 2020
@LaurenWags LaurenWags mentioned this issue Dec 17, 2020
Closed
@rebron rebron changed the title [Desktop] Brave Today intro card should dismiss Brave Today intro card should dismiss Jan 4, 2021
@kjozwiak
Copy link
Member

kjozwiak commented Jan 5, 2021 •
edited
Loading

Verification PASSED on Win 10 x64 using the following builds:

Brave | 1.19.72 Chromium: 87.0.4280.101 (Official Build) beta (64-bit)
-- | --
Revision | 9407c80213cda69c2b7abcb4fa8e3f74488f4956-refs/branch-heads/4280@{#1807}
OS | Windows 10 OS Version 2009 (Build 19042.685)
  • verified the STR/Cases outlined via Brave Today intro card should dismiss #12960 (comment)
  • scrolled through the Brave Today feed quickly so that the intro card wasn't visible for more than 4s and ensured that it was still being displayed in other brave://newtab tabs.
  • viewed the intro card for more than 4s and refreshed the tab, ensured it was removed from the feed
    • ensured that opening new brave://newtab tabs didn't display the intro card
  • ensured that the intro card doesn't re-appear after Brave has been restarted
  • ensured that the intro card doesn't re-appear after toggling Show Brave Today via Customize Dashboard
  • ensured that the intro card doesn't re-appear after clicking on Reset Brave Today Sources via Customize Dashboard

Verification passed on

Brave 1.19.73 Chromium: 87.0.4280.101 (Official Build) dev (64-bit)
Revision 9407c80213cda69c2b7abcb4fa8e3f74488f4956-refs/branch-heads/4280@{#1807}
OS Ubuntu 18.04 LTS
  • verified the STR/Cases outlined via Brave Today intro card should dismiss #12960 (comment)
  • scrolled through the Brave Today feed quickly so that the intro card wasn't visible for more than 4s and ensured that it was still being displayed in other brave://newtab tabs.
  • viewed the intro card for more than 4s and refreshed the tab, ensured it was removed from the feed
    • ensured that opening new brave://newtab tabs didn't display the intro card
  • ensured that the intro card doesn't re-appear after Brave has been restarted
  • ensured that the intro card doesn't re-appear after toggling Show Brave Today via Customize Dashboard
  • ensured that the intro card doesn't re-appear after clicking on Reset Brave Today Sources via Customize Dashboard

Verification PASSED on macOS 11.1 x64 using the following build:

Brave | 1.19.78 Chromium: 87.0.4280.101 (Official Build) dev (x86_64)
-- | --
Revision | 9407c80213cda69c2b7abcb4fa8e3f74488f4956-refs/branch-heads/4280@{#1807}
OS | macOS Version 11.1 (Build 20C69)
  • verified the STR/Cases outlined via Brave Today intro card should dismiss #12960 (comment)
  • scrolled through the Brave Today feed quickly so that the intro card wasn't visible for more than 4s and ensured that it was still being displayed in other brave://newtab tabs.
  • viewed the intro card for more than 4s and refreshed the tab, ensured it was removed from the feed
    • ensured that opening new brave://newtab tabs didn't display the intro card
  • ensured that the intro card doesn't re-appear after Brave has been restarted
  • ensured that the intro card doesn't re-appear after toggling Show Brave Today via Customize Dashboard
  • ensured that the intro card doesn't re-appear after clicking on Reset Brave Today Sources via Customize Dashboard

@kjozwiak kjozwiak mentioned this issue Jan 19, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@petemill petemill

Labels
OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
None yet
Milestone
1.19.x - Release
Development

Successfully merging a pull request may close this issue.

Brave Today: dismiss intro card if it has been viewed for 4 seconds brave/brave-core
3 participants
@petemill @kjozwiak @btlechowski