Brave Today: dismiss intro card if it has been viewed for 4 seconds #7111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanml
reviewed
Nov 10, 2020
| ) | ||
| // don't render if user prefers an empty page | ||
| if (props.newTabData.showEmptyPage && !props.newTabData.isIncognito) { | ||
| return <div /> |
There was a problem hiding this comment.
nit: any reason not to just return null here?
There was a problem hiding this comment.
not sure, I just moved this code from a class to a function (for no particular reason in the end as I didn't use). I think the div is for the blank page? But there's no styling. And in fact this pref is not real. So this code will never fire! We should probably remove that at some point then...
|
Seems like CI is ok, ping @bsclifton @ryanml |
|
@petemill just needs rebase - but I can check out after that 😄 |
petemill
force-pushed
the
brave-today-publisher
branch
from
a68b6c8 to
61d58d6
Compare
Intro Card (and the current tab) has to be fully in view
petemill
force-pushed
the
brave-today-publisher
branch
from
61d58d6 to
098e065
Compare
|
rebased |
|
Linux had unrelated test failure |
This was referenced Dec 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stores a profile pref when the Intro Card (and it's Tab) have been in view for 4 seconds. Does not immediately get removed from page, it just won't show up on the next page load.
Resolves brave/brave-browser#12960
Submitter Checklist:
npm run lint,npm run gn_check)git rebase master(if needed).git rebase -ito squash commits (if needed).QA/YesorQA/No) to the associated issuerelease-notes/includeorrelease-notes/exclude) to the associated issueTest Plan:
On issue
Reviewer Checklist:
After-merge Checklist:
changes has landed on.