Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate BAP modal #13798

Closed
deeppandya opened this issue Jan 27, 2021 · 4 comments · Fixed by brave/brave-core#7817
Closed

Deprecate BAP modal #13798

deeppandya opened this issue Jan 27, 2021 · 4 comments · Fixed by brave/brave-core#7817

Comments

@deeppandya
Copy link

deeppandya commented Jan 27, 2021

This issue is to notify users in japan about the deprecation of BAP.

Main issue : https://github.com/brave/internal/issues/747
Design spec : https://www.figma.com/file/9Pn7htrOeZsbOJ2NcxtxvR/bitFlyer-Promo?node-id=206%3A0

Test plan:

UI and Text test
Screenshot_20210203-002220
Screenshot_20210203-002231

Scenario 1: Non-JP Regions

  • Open the browser in rewards staging environment.
  • Open the rewards panel and claim the promotion.
  • Wait for the promotion value to appear in the wallet balance on the panel.
  • Close the rewards panel and open a new tab.
  • Verify that the BAP popup does not appear on app open.
  • Close the app and remove it from the background
  • Advance the system time to 2021-03-06.
  • Open the app.
  • Verify that the BAP alert does not appear on app open.
  • Close the app and remove it from the background.
  • Advance the system time to 2021-03-13.
  • Open the app and open the rewards panel.
  • Verify that the wallet balance is not zero.

Scenario 2: JP Regions

If wallet balance is zero, app should not show any tooltip.
if wallet balance is non zero,

  • if the date is march 6, 2021 then on the app open user should see the tooltip.
  • if date is between march 6,2021 and march 13, 2021 then user should see the modal directly.
  • if the date is >= march 13, 2021 then user should not see any kind of notice.

For the timing on showing the notice,
once user has seen any kind of notice, either tooltip or modal, the app will set the next notice date to 3 days. So when user opens the app again after 3 days or later user should see the notice based on above conditions based on date.

@kjozwiak
Copy link
Member

kjozwiak commented Feb 8, 2021

Moving this into 1.20.x - Release #3 as 1.20.x - Release #2 will be the 1.20.x Android release as it won't go out on Feb 9th due to translations missing.

@kjozwiak kjozwiak modified the milestones: 1.20.x - Release #3, 1.20.x - Release #2 Feb 8, 2021
@srirambv
Copy link
Contributor

Verification passed on OnePlus 6T with Android 10 running 1.20.104 x64 build

  • Verified steps from issue description
Scenario 1: Non-JP region
  • Verified able to claim promotions
  • Verified no BAP modal is shown
  • Verified no BAP alert is shown when device date is set to 3 Mar 2021
  • Verified no BAP alert is shown when device date is set to 14 Mar 2021
  • Verified wallet balance doesn't change or resets to zero when device date is set to 14 Mar 2021
image image image
Scenario 2: JP region
  • Verified setting device locale to JP shows and clean install(1.20.103) with 0 BAP balance doesn't show any BAP deprecation modal
  • Verified able to claim grant and wallet balance updates
  • Verified upgrading to 1.20.104 with a wallet balance shows the deprecation modal upon launch
  • Verified modal shows up again when the device date is moved ahead by 3 days
  • Verified clicking on learn more brings up a bigger modal with details
  • Verified tapping outside the tooltip closes it
  • Verified clicking only on OK closes the BAP info modal and not tapping outside the modal
  • Verified moving device date ahead by 3 days until Mar 6th, keeps showing both tooltip and modal
  • Verified moving device date to 6 Mar shows only the BAP alert not the tooltip on Rewards
  • Verified moving device date to 13 Mar doesn't show BAP alert or tooltip and wallet balance is reset to 0
  • Verified when device date/time is set to Mar 12 11.59PM, keeping the browser active with a wallet balance is reset to 0 without having to restart the browser
image image image image image

@kjozwiak
Copy link
Member

Moving this into 1.22.x as the BAP work is being reverted via brave/brave-core#8088. Once we have more information next week, we'll re-revert brave/brave-core#8088 and move everything back into 1.21.x and release 1.21.x - Release #2.

@kjozwiak kjozwiak removed this from the 1.22.x - Beta milestone Mar 10, 2021
@srirambv
Copy link
Contributor

Verification passed on Samsung Tab A with Android 10 running 1.21.76 x64 build

  • Verified BAP notice is shown daily
Case 1 - Japan region
  • Verified setting device locale to JP shows and clean install(1.21.74) with 0 BAP balance doesn't show any BAP deprecation modal
  • Verified able to claim grant and wallet balance updates
  • Verified upgrading to 1.21.76 shows BAP deprecation notice if the wallet already had a balance in 1.21.74(GPS build)
  • Verified modal shows up again when the device date is moved ahead by 1 day
  • Verified clicking only on OK closes the BAP info modal and not tapping outside the modal
  • Verified moving device date to 13 Mar doesn't show BAP alert and wallet balance is reset to 0
  • Verified when device date/time is set to Mar 12 11.59PM, keeping the browser active with a wallet balance is reset to 0 without having to restart the browser
image image
Case 2 - non-Japan region
  • Verified able to claim promotions
  • Verified no BAP modal is shown
  • Verified moving date ahead doesn't show any BAP modal
  • Verified moving date to March 13 doesn't reset wallet balance to 0 but instead retains the grant balance
image image

Verification passed on OnePlus 6T with Android 10 running 1.21.76 x64 build

  • Verified BAP notice is shown daily
Case 1 - Japan region
  • Verified setting device locale to JP shows and clean install(1.21.74) with 0 BAP balance doesn't show any BAP deprecation modal
  • Verified able to claim grant and wallet balance updates
  • Verified upgrading to 1.21.76 shows BAP deprecation notice if the wallet already had a balance in 1.21.74(GPS build)
  • Verified modal shows up again when the device date is moved ahead by 1 day
  • Verified clicking only on OK closes the BAP info modal and not tapping outside the modal
  • Verified moving device date to 13 Mar doesn't show BAP alert and wallet balance is reset to 0
  • Verified when device date/time is set to Mar 12 11.59PM, keeping the browser active with a wallet balance is reset to 0 without having to restart the browser
image image
Case 2 - non-Japan region
  • Verified able to claim promotions
  • Verified no BAP modal is shown
  • Verified moving date ahead doesn't show any BAP modal
  • Verified moving date to March 13 doesn't reset wallet balance to 0 but instead retains the grant balance
image image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants