-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate BAP modal #13798
Comments
Moving this into 1.20.x - Release #3 as 1.20.x - Release #2 will be the |
Feature itself is already captured with brave/brave-browser#13798 and brave/brave-browser#13701
Feature itself is already captured with brave/brave-browser#13798 and brave/brave-browser#13701
Moving this into |
Verification passed on Samsung Tab A with Android 10 running 1.21.76 x64 build
Case 1 - Japan region
Case 2 - non-Japan region
Verification passed on OnePlus 6T with Android 10 running 1.21.76 x64 build
Case 1 - Japan region
|
This issue is to notify users in japan about the deprecation of BAP.
Main issue : https://github.com/brave/internal/issues/747
Design spec : https://www.figma.com/file/9Pn7htrOeZsbOJ2NcxtxvR/bitFlyer-Promo?node-id=206%3A0
Test plan:
UI and Text test
Scenario 1: Non-JP Regions
Scenario 2: JP Regions
If wallet balance is zero, app should not show any tooltip.
if wallet balance is non zero,
For the timing on showing the notice,
once user has seen any kind of notice, either tooltip or modal, the app will set the next notice date to 3 days. So when user opens the app again after 3 days or later user should see the notice based on above conditions based on date.
The text was updated successfully, but these errors were encountered: