Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update strings for BAP => BAT transition #8013

Merged
merged 1 commit into from
Feb 23, 2021
Merged

Conversation

bsclifton
Copy link
Member

@bsclifton bsclifton commented Feb 19, 2021

Feature itself is already captured with brave/brave-browser#13798 and brave/brave-browser#13701

Submitter Checklist:

  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)
  • Requested a security/privacy review as needed

Reviewer Checklist:

  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@bsclifton bsclifton requested a review from Miyayes February 19, 2021 17:28
@bsclifton bsclifton self-assigned this Feb 19, 2021
@bsclifton bsclifton marked this pull request as ready for review February 22, 2021 20:48
@bsclifton bsclifton changed the title WIP: Update strings for BAP => BAT transition Update strings for BAP => BAT transition Feb 22, 2021
Copy link

@Miyayes Miyayes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Strings look correct. Thank you!

@bsclifton bsclifton merged commit 4f3af71 into master Feb 23, 2021
@bsclifton bsclifton deleted the bsc-update-bap-text branch February 23, 2021 04:56
brave-builds pushed a commit that referenced this pull request Feb 23, 2021
@bsclifton bsclifton modified the milestones: Closed, 1.22.x - Beta Feb 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants