Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional padding to new tab "+" button #13835

Closed
rebron opened this issue Jan 29, 2021 · 2 comments · Fixed by brave/brave-core#7748
Closed

Add additional padding to new tab "+" button #13835

rebron opened this issue Jan 29, 2021 · 2 comments · Fixed by brave/brave-core#7748
Assignees
Labels
design A design change, especially one which needs input from the design team OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include usability

Comments

@rebron
Copy link
Collaborator

rebron commented Jan 29, 2021

Description

Tabs, specifically the close button, and the "new tab" button are close together and could use additional padding/separation to improve closing a tab or selecting a new tab by mistake.

Other browsers like Chrome and Yandex have slightly bigger padding and separation between buttons.

Steps to Reproduce and Actual Result:

Noticeable with a new window and notice spacing between a tab's close button and the new tab icon.

image__2_

Expected result:

[placeholder for design] @karenkliu

Reproduces how often:

Easy

Brave version (brave://version info)

All.

Version/Channel Information:

  • Can you reproduce this issue with the current release? yes
  • Can you reproduce this issue with the beta channel? yes
  • Can you reproduce this issue with the nightly channel? yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? n/a
  • Does the issue resolve itself when disabling Brave Rewards? n/a
  • Is the issue reproducible on the latest version of Chrome? no

Miscellaneous Information:

@rebron rebron added OS/Desktop design A design change, especially one which needs input from the design team labels Jan 29, 2021
@rebron rebron added the priority/P3 The next thing for us to work on. It'll ride the trains. label Jan 29, 2021
simonhong added a commit to brave/brave-core that referenced this issue Jan 29, 2021
@bsclifton bsclifton added this to the 1.21.x - Nightly milestone Feb 1, 2021
@bsclifton
Copy link
Member

Added missing milestone

@stephendonner
Copy link

stephendonner commented Feb 8, 2021

Verified using inline testplan on

Brave 1.21.44 Chromium: 88.0.4324.146 (Official Build) beta (x86_64)
Revision 406dc88511162d6598242f2c709be1414a042fb0-refs/branch-heads/4324@{#2088}
OS macOS Version 11.2 (Build 20D64)

In addition to the increased horizontal margin padding between tab-close (X) and open new tab (+), I checked:

  • hover states
  • click states
1.19.92 1.21.44
image image

Verification passed on

Brave 1.21.52 Chromium: 88.0.4324.152 (Official Build) dev (64-bit)
Revision 6579930fc53b4dc589c042bec9d0a3778326974d-refs/branch-heads/4324@{#2106}
OS Ubuntu 18.04 LTS

Verified test plan from the description. Verified hover and click states

1.20.103 1.21.52
image image

Verification passed on


Brave | 1.21.56 Chromium: 88.0.4324.152 (Official Build) dev (64-bit)
-- | --
Revision | 6579930fc53b4dc589c042bec9d0a3778326974d-refs/branch-heads/4324@{#2106}
OS | Windows 10 OS Version 2004 (Build 19041.804)


Verified the spacing additional padding to new tab "+" button

1.20.x Vs 1.21.x
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design A design change, especially one which needs input from the design team OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include usability
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants