Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTP subresources on ipfs are blocked even when Shields are disabled #14147

Closed
btlechowski opened this issue Feb 13, 2021 · 6 comments · Fixed by brave/brave-core#8106
Closed
Assignees
Labels
feature/shields The overall Shields feature in Brave. feature/web3/ipfs OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-macOS QA/Test-Plan-Specified QA/Yes release-notes/include

Comments

@btlechowski
Copy link

btlechowski commented Feb 13, 2021

Follow up to #13742. The resources are blocked, even when Shields are disabled

Steps to Reproduce

  1. Clean profile
  2. Open ipfs://bafybeiemxf5abjwjbikoz4mc3a3dla6ual3jsgpdr4cjr3oz3evfyavhwq/wiki/Vincent_van_Gogh.html
  3. Enable IPFS to use local node
  4. Open ipfs://bafybeiemxf5abjwjbikoz4mc3a3dla6ual3jsgpdr4cjr3oz3evfyavhwq/wiki/Vincent_van_Gogh.html in a new tab
  5. Disable Shields
  6. Open console
  7. Paste:
var script = document.createElement('script')
script.src = 'https://brianbondy.com/static/js/analytics.js'
document.body.appendChild(script)

Actual result:

HTTP subresources on ipfs are blocked when Shields are disabled
image

After waiting 60seconds, next to disabled Shields icon, 1 is shown
image

Expected result:

HTTP subresources on ipfs are not blocked when Shields are disabled

Reproduces how often:

100% repro rate

Brave version (brave://version info)

Brave 1.21.52 Chromium: 88.0.4324.152 (Official Build) dev (64-bit)
Revision 6579930fc53b4dc589c042bec9d0a3778326974d-refs/branch-heads/4324@{#2106}
OS Ubuntu 18.04 LTS
Brave 1.22.23 Chromium: 89.0.4389.48 (Official Build) nightly (64-bit)
Revision 0fe3c4589a6cf5ce719d167834dfa9cd8978937a-refs/branch-heads/4389@{#873}
OS Linux

cc @brave/legacy_qa @rebron @bbondy

@bbondy
Copy link
Member

bbondy commented Feb 14, 2021

Just tried this and did not reproduce, it loads the resource when shields are disabled for me.

@btlechowski
Copy link
Author

Just reproduced it on Windows on latest nightly

Brave 1.22.22 Chromium: 89.0.4389.40 (Oficjalna wersja) nightly (64-bitowa)
Wersja 2c2ed83cd507b23e4845edd09a7d1dfc727daf4b-refs/branch-heads/4389@{#602}
System operacyjny Windows 7 Service Pack 1 (Build 7601.24544)

I disabled Shields and the element was still blocked, it even shows that it blocked 1 element:
image
image

@bbondy What system and what Brave version have you tried?

@LaurenWags
Copy link
Member

Reproduces on macOS x64 10.15.7:

Brave | 1.22.24 Chromium: 89.0.4389.48 (Official Build) nightly (x86_64)
-- | --
Revision | 0fe3c4589a6cf5ce719d167834dfa9cd8978937a-refs/branch-heads/4389@{#873}
OS | macOS Version 10.15.7 (Build 19H512)

Used STR from the description on a clean profile:
Screen Shot 2021-02-15 at 8 21 47 AM
Screen Shot 2021-02-15 at 8 21 12 AM

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Feb 15, 2021

Reproduced the issue in Windows 10 x64 - Version 1.22.22 Chromium: 89.0.4389.40

image

@bbondy
Copy link
Member

bbondy commented Feb 17, 2021

I can reproduce, thanks.

@bbondy bbondy added the priority/P3 The next thing for us to work on. It'll ride the trains. label Feb 17, 2021
@spylogsster spylogsster self-assigned this Mar 1, 2021
@spylogsster spylogsster added this to the 1.23.x - Nightly milestone Mar 3, 2021
@stephendonner
Copy link

Verified FIXED using nightly build

Brave 1.23.19 Chromium: 89.0.4389.72 (Official Build) nightly (x86_64)
Revision 3f345f156bfd157bd1bea06310e55f3fb2490359-refs/branch-heads/4389@{#1393}
OS macOS Version 11.2.2 (Build 20D80)

Verification steps

  1. Clean profile
  2. Open ipfs://bafybeiemxf5abjwjbikoz4mc3a3dla6ual3jsgpdr4cjr3oz3evfyavhwq/wiki/Vincent_van_Gogh.html
  3. Enable IPFS to use local node
  4. Open ipfs://bafybeiemxf5abjwjbikoz4mc3a3dla6ual3jsgpdr4cjr3oz3evfyavhwq/wiki/Vincent_van_Gogh.html in a new tab
  5. Disable Shields
  6. Open console
  7. Paste:
var script = document.createElement('script')
script.src = 'https://brianbondy.com/static/js/analytics.js'
document.body.appendChild(script)

Verified that there are no blocked IPFS elements when Shields are down:

Screen Shot 2021-03-04 at 3 36 21 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/shields The overall Shields feature in Brave. feature/web3/ipfs OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-macOS QA/Test-Plan-Specified QA/Yes release-notes/include
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants