click on Enable IPFS is redirected to Choose default apps by protocol windows settings

[GeetaSarvadnya]

Description

Found while testing #14147
click on Enable IPFS is redirected to Choose default apps by protocol windows settings

Steps to Reproduce

1. Clean profile
2. Open ipfs://bafybeiemxf5abjwjbikoz4mc3a3dla6ual3jsgpdr4cjr3oz3evfyavhwq/wiki/Vincent_van_Gogh.html
3. Enable IPFS to use local node

Actual result:

click on Enable IPFS is redirected to Choose default apps by protocol windows settings

Expected result:

Should not redirect to any windows settings

Reproduces how often:

Easy

Brave version (brave://version info)

Brave	1.22.22 Chromium: 89.0.4389.40 (Official Build) nightly (64-bit)
Revision	2c2ed83cd507b23e4845edd09a7d1dfc727daf4b-refs/branch-heads/4389@{#602}
OS	Windows 10 OS Version 2004 (Build 19041.804)

Version/Channel Information:

• Can you reproduce this issue with the current release? No
• Can you reproduce this issue with the beta channel? No
• Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

• Does the issue resolve itself when disabling Brave Shields? NA
• Does the issue resolve itself when disabling Brave Rewards? NA
• Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @brave/legacy_qa @bbondy @rebron

Please note issue isn't reproducible for @LaurenWags in macOS and @btlechowski in Windows 7

Looks like a Windows 10 x64 specific issue

[spylogsster]

In order to setup protocol handlers we rely on chromium implementation. In case of win10 it shows Windows UI Settings to allow user to choose protocol handlers from the list. After short discussion with @bbondy we decided to leave it as is, but add Brave to the list of apps. @GeetaSarvadnya

[GeetaSarvadnya]

@spylogsster I have selected IPFS Brave Nightly from the protocol handler settings, I didn't get the protocol handle settings popup again when I Enable IPFS. I didn't face this issue while testing IPFS on released version 1.20.x. I am seeing this issue only in 1.22.x.

[spylogsster]

yes @GeetaSarvadnya it appears only once if Brave is not default protocol handler here, otherwise it will not be shown.

[stephendonner]

Verified FIXED on nightly using

Brave	1.22.39 Chromium: 89.0.4389.58 (Official Build) nightly (x86_64)
Revision	1a139f28ecc27719439e37c6b1533cee999cb802-refs/branch-heads/4389@{#1134}
OS	macOS Version 11.2.1 (Build 20D74)

---

Verification passed on

Brave | 1.22.50 Chromium: 89.0.4389.72 (Official Build) dev (64-bit)
-- | --
Revision | 3f345f156bfd157bd1bea06310e55f3fb2490359-refs/branch-heads/4389@{#1393}
OS | Windows 10 OS Version 2004 (Build 19041.804)

• Verified the STR from the description and ensured that the choose default apps by protocol windows settings popup is not shown after clicking on Enable IPFS