-
Notifications
You must be signed in to change notification settings - Fork 879
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add brave to list of apps for ipfs/ipns protocols #7966
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spylogsster
force-pushed
the
add-app-to-protocol-list
branch
from
February 15, 2021 18:31
24953ba
to
fa707db
Compare
I'm ok with the changes but @mkarolin could you advise on if there's a better way to do the patching? |
mkarolin
reviewed
Feb 16, 2021
mkarolin
reviewed
Feb 16, 2021
mkarolin
reviewed
Feb 16, 2021
spylogsster
force-pushed
the
add-app-to-protocol-list
branch
2 times, most recently
from
February 17, 2021 08:20
38725c3
to
fd743a2
Compare
mkarolin
reviewed
Feb 17, 2021
spylogsster
force-pushed
the
add-app-to-protocol-list
branch
from
February 17, 2021 15:26
fd743a2
to
3d1f22d
Compare
mkarolin
approved these changes
Feb 17, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
chromium_src
and patches
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#14161
In order to setup protocol handlers we rely on chromium implementation. In case of win10 it shows Windows UI Settings to allow user to choose protocol handlers from the list. After short discussion we decided leave it as is but add Brave to the list of apps.
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
,npm run lint
,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan: