Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add brave to list of apps for ipfs/ipns protocols #7966

Merged
merged 2 commits into from
Feb 17, 2021

Conversation

spylogsster
Copy link
Contributor

@spylogsster spylogsster commented Feb 15, 2021

Resolves brave/brave-browser#14161

In order to setup protocol handlers we rely on chromium implementation. In case of win10 it shows Windows UI Settings to allow user to choose protocol handlers from the list. After short discussion we decided leave it as is but add Brave to the list of apps.

image

Submitter Checklist:

  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)
  • Requested a security/privacy review as needed

Reviewer Checklist:

  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  • Remove default protocols handler for ipfs/ipns
  • Clean profile
  • Open ipfs://bafybeiemxf5abjwjbikoz4mc3a3dla6ual3jsgpdr4cjr3oz3evfyavhwq/wiki/Vincent_van_Gogh.html
  • Enable IPFS to use local node
  • Browser opens a settings window and brave should be in the list of handlers for ipfs/ipns protocols

@spylogsster spylogsster requested a review from a team as a code owner February 15, 2021 18:18
@spylogsster spylogsster self-assigned this Feb 15, 2021
@bbondy bbondy requested a review from mkarolin February 16, 2021 15:56
@bbondy
Copy link
Member

bbondy commented Feb 16, 2021

I'm ok with the changes but @mkarolin could you advise on if there's a better way to do the patching?

@spylogsster spylogsster force-pushed the add-app-to-protocol-list branch 2 times, most recently from 38725c3 to fd743a2 Compare February 17, 2021 08:20
Copy link
Collaborator

@mkarolin mkarolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

chromium_src and patches LGTM

@bbondy bbondy merged commit 7d777c6 into master Feb 17, 2021
@bbondy bbondy deleted the add-app-to-protocol-list branch February 17, 2021 19:43
@spylogsster spylogsster added this to the 1.22.x - Nightly milestone Feb 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

click on Enable IPFS is redirected to Choose default apps by protocol windows settings
3 participants