Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'Set Brave as your default browser' dialog on 2nd and nth launch is not translated #14177

Closed
btlechowski opened this issue Feb 16, 2021 · 2 comments

Comments

@btlechowski
Copy link

Follow up to #12203

Steps to Reproduce

  1. Clean Profile
  2. Run Brave in Polish (PL) locale
  3. Uncheck Set Brave as your default browser
  4. Click OK
  5. Open New tab
  6. Relaunch browser

Actual result:

'Set Brave as your default browser' dialog is not translated
image

Expected result:

'Set Brave as your default browser' dialog is translated

Reproduces how often:

Easily reproduced

Brave version (brave://version info)

Brave 1.21.56 Chromium: 88.0.4324.152 (Official Build) dev (64-bit)
Revision 6579930fc53b4dc589c042bec9d0a3778326974d-refs/branch-heads/4324@{#2106}
OS Ubuntu 18.04 LTS

cc @brave/legacy_qa @rebron @mkarolin

@kjozwiak
Copy link
Member

kjozwiak commented Mar 2, 2021

As per #14369 (comment), moving issue into https://github.com/brave/brave-browser/milestone/167 now that brave/brave-core#8093 was merged into 1.22.x and 1.21.x via brave/brave-core#8096 & brave/brave-core#8097.

@brave/legacy_qa if it's still an issue, please re-open and remove it from the milestone as there was no code associated with the issues so we can just re-open then and decide if it's release blocking or not.

@kjozwiak kjozwiak added this to the 1.21.x - Release milestone Mar 2, 2021
@kjozwiak kjozwiak closed this as completed Mar 2, 2021
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Mar 2, 2021

Verification passed on


Brave | 1.21.71 Chromium: 89.0.4389.72 (ಅಧಿಕೃತವಾಗಿ ನಿರ್ಮಿಸಿ) (64-ಬಿಟ್)
-- | --
ಪರಿಷ್ಕರಣೆ | 3f345f156bfd157bd1bea06310e55f3fb2490359-refs/branch-heads/4389@{#1393}
OS | Windows 10 OS Version 2004 (Build 19041.804)

  • Verified that set brave as default browser dialog is translated in Kannada, Germany and France locales
    Kannada
    image

Germany
Encountered #14431
image

France
image

Verification passed on

Brave 1.21.71 Chromium: 89.0.4389.72 (Official Build) (64-bit)
Revision 3f345f156bfd157bd1bea06310e55f3fb2490359-refs/branch-heads/4389@{#1393}
OS Ubuntu 18.04 LTS

Polish PL locale
image

Logged #14432


Verified passed with

Brave | 1.21.71 Chromium: 89.0.4389.72 (Official Build) (x86_64)
-- | --
Revision | 3f345f156bfd157bd1bea06310e55f3fb2490359-refs/branch-heads/4389@{#1393}
OS | macOS Version 10.15.7 (Build 19H512)

Verified STR from description for below languages. Note, encountered #14431 (comment) for certain languages. Not all languages seem to be affected.

Spanish (Spain) French (France) Japanese
Spanish-Spain French Japanese

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants