'Set browser as default' dialog on 2nd and nth launch #12203

karenkliu · 2020-10-19T23:51:17Z

Description

One of the issues made evident from lapsed user research is that we can do better in encouraging users to set Brave as their default browser.

Currently, the "set browser dialog" is displayed as a non-user-blocking infobar on 2nd launch.

Designs

Change the infobar to a user-blocking browser dialog to encourage interaction.

Brave will check if it has been set as the default browser on every launch. This dialog reappears:

If the user hits "not now", the dialog reappears on the 3rd, 4th, 8th, and 20th launch.
If the user had set Brave as the default, and then it was not the default on next launch (possibly due to updating OS), then show the dialog regardless of the nth launch

Dark theme is supported:

Assets

Figma: https://www.figma.com/file/MFHpcXJMg2RUQpUJMAZZ4R/?node-id=146%3A0

Note

This is a follow up issue to:

MacOS first launch: Set default browser first_run dialog on macOS and Linux #12679
Windows first launch: Reduce length of welcome experience #12680

karenkliu · 2020-11-19T22:05:03Z

@rebron When do you want this to dialog to show again if the user selects "not now" ?

karenkliu · 2021-01-05T18:07:37Z

@rebron @bsclifton For this issue, we need to finish defining the reappearance of the dialog. What are your thoughts on this cadence (and if it's feasible):

If the user hits "not now", the dialog reappears on the 3rd, 4th, 8th, and 20th launch.
If the user had set Brave as the default, and then it was not the default on next launch (possibly due to updating OS), then show the dialog regardless of the nth launch

bsclifton · 2021-01-11T23:44:07Z

I like the frequency - I think it makes sense to not reset the count if browser was set as default and then was removed as default. Basically the frequency is only incremented if you launch Brave + it's not default

karenkliu · 2021-01-20T19:44:33Z

Check that when we implement this issue it also fixes #9306

simonhong · 2021-01-27T08:06:33Z

Just a note.
In chromium, dismissed infobar is re-appearred after some days passed. period_days.
In our case, fetched period_days is zero.
I don't know about this variation subsystem. Maybe we don't show again after it's dismissed first time.
@iefremov @bsclifton Do you know we configure this variation value?

  if (last_dismissed_value) {
    int period_days = 0;
    base::StringToInt(variations::GetVariationParamValue(
                          "DefaultBrowserInfobar", "RefreshPeriodDays"),
                      &period_days);
    if (period_days <= 0 || period_days == std::numeric_limits<int>::max())
      return false;  // Failed to parse a reasonable period.
    base::Time show_on_or_after =
        base::Time::FromInternalValue(last_dismissed_value) +
        base::TimeDelta::FromDays(period_days);
    if (base::Time::Now() < show_on_or_after)
      return false;
  }

@rebron @karenkliu and we don't show dialog anymore after 20th launch?

fix brave/brave-browser#12203

Browser will launch window modal dialog at 2nd, 3rd, 4th, 8th and 20th launching if browser is not a default. If browser is changed from default to non-default, browser will launch dialog again with same frequency. fix brave/brave-browser#12203

This could bother developers. F/U PR for #7716. fix brave/brave-browser#12203

btlechowski · 2021-02-16T12:41:54Z

Verification passed on

Brave	1.21.56 Chromium: 88.0.4324.152 (Official Build) dev (64-bit)
Revision	6579930fc53b4dc589c042bec9d0a3778326974d-refs/branch-heads/4324@{#2106}
OS	Ubuntu 18.04 LTS

Brave	1.21.47 Chromium: 88.0.4324.152 (Official Build) beta (64-bit)
Revision	6579930fc53b4dc589c042bec9d0a3778326974d-refs/branch-heads/4324@{#2106}
OS	Ubuntu 18.04 LTS

Brave	1.22.26 Chromium: 89.0.4389.48 (Official Build) nightly (64-bit)
Revision	0fe3c4589a6cf5ce719d167834dfa9cd8978937a-refs/branch-heads/4389@{#873}
OS	Ubuntu 18.04 LTS

Brave	1.21.68 Chromium: 89.0.4389.58 (Official Build) (64-bit)
Revision	1a139f28ecc27719439e37c6b1533cee999cb802-refs/branch-heads/4389@{#1134}
OS	Ubuntu 18.04 LTS

Verified test plan from brave/brave-core#7716

Important: Make any browser except Brave (any channel) the default browser

Verified default browser dialog is shown after 2nd, 3rd, 4th, 8th and 20th launch. Verified brave->default_browser->launching_count in Preferences is increased each browser launch

Verified dialog is no longer shown after the browser is made default.

Verified dialog is shown after another browser is made default. Verified brave->default_browser->launching_count in Preferences starts from 1.

Verified dialog is not shown when brave://welcome page is active tab.

Verified on upgrade profile (1.20.x) that default browser dialog is shown.

Logged #14177 for missing translations

Encountered #13980.

Verified PASSED on nightly, dev, and beta builds, macOS 11.2.1 (Big Sur) using:

Brave	1.22.42 Chromium: 89.0.4389.58 (Official Build) nightly (x86_64)
Revision	1a139f28ecc27719439e37c6b1533cee999cb802-refs/branch-heads/4389@{#1134}
OS	macOS Version 11.2.1 (Build 20D74)

Brave	1.21.66 Chromium: 88.0.4324.182 (Official Build) dev (x86_64)
Revision	73ee5087001dcef33047c4ed650471b225dd8caf-refs/branch-heads/4324@{#2202}
OS	macOS Version 11.2.1 (Build 20D74)

Brave	1.21.65 Chromium: 88.0.4324.182 (Official Build) beta (x86_64)
Revision	73ee5087001dcef33047c4ed650471b225dd8caf-refs/branch-heads/4324@{#2202}
OS	macOS Version 11.2.1 (Build 20D74)

using the testplan from brave/brave-core#7716

Verified:

both dark and light themes
default-browser dialog appears on the 2nd, 3rd, 4th, 8th, and 20th launches
the above dialog does NOT appear on launches 9-19
after choosing "Set as default", in the Brave dialog, then confirming with the OS-level dialog, the user is no longer prompted to set their default browser, on restart
after the 20th launch, regardless of choosing Not Now or Set as default the modal dialog did NOT appear

Launches:

screenshots

2nd

3rd

4th

8th

20th

btlechowski · 2021-02-16T13:56:28Z

Set as QA/Blocked till we get a release channel build as the issue needs to be tested on all channels.

LaurenWags · 2021-02-25T13:12:13Z

Removing QA/Blocked since https://github.com/brave/brave-browser/releases/tag/v1.21.68 is available

stephendonner · 2021-02-25T23:05:41Z

Verified FIXED on release build, macOS 11.2.2 (Big Sur) using the testplan from brave/brave-core#7716 on:

Brave	1.21.68 Chromium: 89.0.4389.58 (Official Build) (x86_64)
Revision	1a139f28ecc27719439e37c6b1533cee999cb802-refs/branch-heads/4389@{#1134}
OS	macOS Version 11.2.2 (Build 20D80)

Verified:

both dark and light themes (only light pictured, sorry)
default-browser dialog appears on the 2nd, 3rd, 4th, 8th, and 20th launches
the above dialog does NOT appear on launches 9-19
after choosing "Set as default", in the Brave dialog, then confirming with the OS-level dialog, the user is no longer prompted to set their default browser, on restart
after the 20th launch, regardless of choosing Not Now or Set as default the modal dialog did NOT appear

Launches:

2nd	3rd	4th	8th	20th

Verification passed on

Brave | 1.21.68 Chromium: 89.0.4389.58 (Official Build) (64-bit)
-- | --
Revision | 1a139f28ecc27719439e37c6b1533cee999cb802-refs/branch-heads/4389@{#1134}
OS | Windows 10 OS Version 2004 (Build 19041.804)

Verified the test plan from Show default browser dialog instead of infobar brave-core#7716

both dark and light themes
default-browser dialog appears on the 2nd, 3rd, 4th, 8th, and 20th launches
the above dialog does NOT appear on launches 9-19
after choosing "Set as default", in the Brave dialog, then confirming with the OS-level dialog, the user is no longer prompted to set their default browser, on restart
after the 20th launch, regardless of choosing Not Now or Set as default the modal dialog did NOT appear

Launches:

2nd	3rd	4th	8th	20th

karenkliu added OS/Android Fixes related to Android browser functionality OS/Desktop labels Oct 19, 2020

karenkliu assigned rebron Oct 19, 2020

karenkliu changed the title ~~[Desktop] Include Set browser as default in the welcome experience~~ [Desktop] More aggressive Set browser as default dialog on 2nd launch Nov 12, 2020

rebron added the priority/P3 The next thing for us to work on. It'll ride the trains. label Nov 18, 2020

karenkliu mentioned this issue Nov 19, 2020

Reduce length of welcome experience #12680

Closed

rebron added priority/P2 A bad problem. We might uplift this to the next planned release. and removed priority/P3 The next thing for us to work on. It'll ride the trains. labels Jan 11, 2021

rebron changed the title ~~[Desktop] More aggressive Set browser as default dialog on 2nd launch~~ [Desktop] Set browser as default dialog on 2nd launch Jan 11, 2021

rebron changed the title ~~[Desktop] Set browser as default dialog on 2nd launch~~ Set browser as default dialog on 2nd launch Jan 11, 2021

rebron assigned simonhong Jan 25, 2021

rebron added QA/Yes release-notes/include labels Jan 25, 2021

rebron removed their assignment Jan 27, 2021

rebron removed the OS/Android Fixes related to Android browser functionality label Jan 27, 2021

rebron changed the title ~~Set browser as default dialog on 2nd launch~~ 'Set browser as default' dialog on 2nd and nth launch Jan 27, 2021

simonhong mentioned this issue Jan 27, 2021

Show default browser dialog instead of infobar brave/brave-core#7716

Merged

23 tasks

simonhong added a commit to brave/brave-core that referenced this issue Jan 28, 2021

WIP: Show default browser dialog instead of infobar

8dc2da8

fix brave/brave-browser#12203

simonhong closed this as completed in brave/brave-core#7716 Feb 2, 2021

simonhong added this to the 1.21.x - Nightly milestone Feb 2, 2021

simonhong added a commit to brave/brave-core that referenced this issue Feb 2, 2021

Disable default browser modal for non-official build

ef26466

This could bother developers. F/U PR for #7716. fix brave/brave-browser#12203

simonhong mentioned this issue Feb 2, 2021

Disable default browser modal for non-official build brave/brave-core#7772

Merged

23 tasks

karenkliu mentioned this issue Feb 2, 2021

[Desktop] Brave has no option to prevent "Set default browser" notification appearing repeatedly #9306

Closed

btlechowski added the QA Pass-Linux label Feb 16, 2021

btlechowski mentioned this issue Feb 16, 2021

'Set Brave as your default browser' dialog on 2nd and nth launch is not translated #14177

Closed

btlechowski removed the QA Pass-Linux label Feb 16, 2021

btlechowski added the QA/Blocked label Feb 16, 2021

LaurenWags removed the QA/Blocked label Feb 25, 2021

stephendonner added the QA Pass-macOS label Feb 25, 2021

GeetaSarvadnya added the QA Pass-Win64 label Feb 26, 2021

btlechowski added the QA Pass-Linux label Feb 26, 2021

LaurenWags mentioned this issue Mar 1, 2021

[Desktop] Release Notes for 1.21.x Release #1 #14415

Closed

rebron mentioned this issue Mar 5, 2021

follow-up to #12203 reduce dialog frequency to display twice #14502

Closed

LaurenWags mentioned this issue Mar 7, 2021

[Desktop] Release Notes for 1.21.x Release #2 #14536

Closed

LaurenWags mentioned this issue May 4, 2021

[Desktop] Release Notes for 1.24.x Release #1 #15610

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

'Set browser as default' dialog on 2nd and nth launch #12203

'Set browser as default' dialog on 2nd and nth launch #12203

karenkliu commented Oct 19, 2020 •

edited

Loading

karenkliu commented Nov 19, 2020

karenkliu commented Jan 5, 2021

bsclifton commented Jan 11, 2021

karenkliu commented Jan 20, 2021

simonhong commented Jan 27, 2021 •

edited

Loading

btlechowski commented Feb 16, 2021 •

edited

Loading

btlechowski commented Feb 16, 2021

LaurenWags commented Feb 25, 2021

stephendonner commented Feb 25, 2021 •

edited by GeetaSarvadnya

Loading

'Set browser as default' dialog on 2nd and nth launch #12203

'Set browser as default' dialog on 2nd and nth launch #12203

Comments

karenkliu commented Oct 19, 2020 • edited Loading

Description

Designs

Assets

Note

karenkliu commented Nov 19, 2020

karenkliu commented Jan 5, 2021

bsclifton commented Jan 11, 2021

karenkliu commented Jan 20, 2021

simonhong commented Jan 27, 2021 • edited Loading

btlechowski commented Feb 16, 2021 • edited Loading

btlechowski commented Feb 16, 2021

LaurenWags commented Feb 25, 2021

stephendonner commented Feb 25, 2021 • edited by GeetaSarvadnya Loading

karenkliu commented Oct 19, 2020 •

edited

Loading

simonhong commented Jan 27, 2021 •

edited

Loading

btlechowski commented Feb 16, 2021 •

edited

Loading

stephendonner commented Feb 25, 2021 •

edited by GeetaSarvadnya

Loading