Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable default browser modal for non-official build #7772

Merged
merged 1 commit into from
Feb 2, 2021

Conversation

simonhong
Copy link
Member

@simonhong simonhong commented Feb 2, 2021

This could bother developers.
F/U PR for #7716.

fix brave/brave-browser#12203

Resolves

Submitter Checklist:

  • There is a ticket for my issue.
  • Used Github auto-closing keywords in the commit message.
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed).
  • Requested a security/privacy review as needed.

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  1. Build non-official brave
  2. Launch it with clean profile
  3. Check default browser dialog is not launched

@simonhong simonhong self-assigned this Feb 2, 2021
@simonhong simonhong requested a review from bsclifton February 2, 2021 03:01
Copy link
Member

@bsclifton bsclifton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Definitely important to have this

We should be able to check channel also - as it would be Development for local. But I think official build would work better 😄

@bsclifton bsclifton added this to the 1.21.x - Nightly milestone Feb 2, 2021
@bsclifton bsclifton merged commit 4ba48d2 into master Feb 2, 2021
@bsclifton bsclifton deleted the disable_default_browser_modal_in_non_official branch February 2, 2021 08:59
@simonhong
Copy link
Member Author

@bsclifton thanks for merging 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'Set browser as default' dialog on 2nd and nth launch
2 participants