Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"New Tor Connection For This Site" is capitalized weirdly #14270

Closed
wyatt400 opened this issue Feb 20, 2021 · 4 comments · Fixed by brave/brave-core#8034
Closed

"New Tor Connection For This Site" is capitalized weirdly #14270

wyatt400 opened this issue Feb 20, 2021 · 4 comments · Fixed by brave/brave-core#8034
Assignees
Labels
feature/tor needs-text-change This change requires some careful wording. OS/Desktop priority/P4 Planned work. We expect to get to it "soon". QA Pass-macOS QA/Yes release-notes/exclude

Comments

@wyatt400
Copy link

"New Tor Connection For This Site" on the Desktop Brave Browser is capitalized weirdly. All of the other menu items are capitalized in a different format.

Steps to reproduce:

  1. Open the Brave Browser on Desktop
  2. Open a New TOR Window
  3. Click the Menu Icon

Actual: "New Tor Connection For This Site" shows.

Expected: "New Tor connection for this site" shows.

Reproduces how often?
Always reproduces.

Brave version: 1.20.103
Chromium version: 88.0.4324.152

Happens on all channels and versions.

  • Does the issue resolve itself when disabling Brave Shields? No
  • Does the issue resolve itself when disabling Brave Rewards? No
  • Is the issue reproducible on the latest version of Chrome? No (because Chrome doesn't have TOR)
@bsclifton bsclifton added the needs-text-change This change requires some careful wording. label Feb 22, 2021
@bsclifton
Copy link
Member

cc: @rebron @bradleyrichter we were using the title casing across the board - should we update this?

@rebron
Copy link
Collaborator

rebron commented Feb 22, 2021

We've been moving to sentence casing in settings, we should make change here too.
cc: @karenkliu

@rebron rebron added the priority/P4 Planned work. We expect to get to it "soon". label Feb 22, 2021
@karenkliu
Copy link

Right, the title casing is from Apple. On desktop we've been moving to all sentence casing. iOS has made the choice to stick with title casing since mobile designs adhere more strictly to the OS styling.

@stephendonner
Copy link

Verified FIXED on beta using

Brave 1.22.49 Chromium: 89.0.4389.72 (Official Build) beta (x86_64)
Revision 3f345f156bfd157bd1bea06310e55f3fb2490359-refs/branch-heads/4389@{#1393}
OS macOS Version 11.2.2 (Build 20D80)

Verified the string is "New Tor connection for this site"

Screen Shot 2021-03-02 at 2 59 42 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/tor needs-text-change This change requires some careful wording. OS/Desktop priority/P4 Planned work. We expect to get to it "soon". QA Pass-macOS QA/Yes release-notes/exclude
Projects
None yet
5 participants