Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update casing for "New Tor Connection For This Site" #8034

Merged
merged 1 commit into from
Feb 22, 2021

Conversation

bsclifton
Copy link
Member

Fixes brave/brave-browser#14270

Submitter Checklist:

  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)
  • Requested a security/privacy review as needed

Reviewer Checklist:

  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@bsclifton bsclifton added the CI/skip Do not run CI builds (except noplatform) label Feb 22, 2021
@bsclifton bsclifton self-assigned this Feb 22, 2021
Copy link
Collaborator

@rebron rebron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@bsclifton bsclifton merged commit 331f3f1 into master Feb 22, 2021
@bsclifton bsclifton deleted the bsc-wyatt-text-change branch February 22, 2021 19:47
@bsclifton bsclifton added this to the 1.22.x - Nightly milestone Feb 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip Do not run CI builds (except noplatform)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"New Tor Connection For This Site" is capitalized weirdly
3 participants