Private, Tor, Guest windows are missing image

[LaurenWags]

Description

Found by @simonhong

Private, Tor, Guest windows are missing the image.

Does not reproduce in 1.22.28, but does reproduce in 1.22.34, 1.22.37, etc.

Steps to Reproduce

1. Install 1.22.28, open Private, Tor, Guest windows. See expected image.
2. Upgrade to newer version.
3. Open Private, Tor, Guest windows.

Actual result:

Private	Tor	Guest

Expected result:

Private	Tor	Guest

Reproduces how often:

100%

Brave version (brave://version info)

1.22.28 CR: 89.0.4389.48 --> does not reproduce
1.22.34 CR: 89.0.4389.48 --> does reproduce
1.22.37 CR: 89.0.4389.58 --> does reproduce

Version/Channel Information:

• Can you reproduce this issue with the current release? no, 1.20.x
• Can you reproduce this issue with the beta channel? no, 1.21.x
• Can you reproduce this issue with the nightly channel? certain versions of 1.22.x

Other Additional Information:

• Does the issue resolve itself when disabling Brave Shields?
• Does the issue resolve itself when disabling Brave Rewards?
• Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

cc @rebron @brave/legacy_qa

[kjozwiak]

Reproducible on Win 10 x64 as well via the following build:

Brave | 1.22.42 Chromium: 89.0.4389.58 (Official Build) nightly (64-bit)
-- | --
Revision | 1a139f28ecc27719439e37c6b1533cee999cb802-refs/branch-heads/4389@{#1134}
OS | Windows 10 OS Version 2009 (Build 19042.804)

[kjozwiak]

We'll want this one uplifted into 1.21.x after we today's channel migrations.

[mkarolin]

Version 1.22.29 is already broken. Reverting brave/brave-core#7967 (brave/brave-core@8dc5ce7) fixes it. cc: @petemill @mihaiplesa

[bsclifton]

Nice find @mkarolin 😄 I'll submit a PR real quick

[bsclifton]

Manually reverted in master and in 1.22.x. Problem shouldn't be in 1.21.x as brave/brave-core#7967 landed in 1.22.x 👍

[stephendonner]

Verified FIXED on beta using

Brave	1.22.49 Chromium: 89.0.4389.72 (Official Build) beta (x86_64)
Revision	3f345f156bfd157bd1bea06310e55f3fb2490359-refs/branch-heads/4389@{#1393}
OS	macOS Version 11.2.2 (Build 20D80)

Confirmed there are no missing images, and that Tor still initializes properly in New Private Window with Tor

Private	Tor	Guest