Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Update dependency file-loader to v6 (#7967)" #8057

Merged
merged 1 commit into from
Feb 24, 2021

Conversation

bsclifton
Copy link
Member

@bsclifton bsclifton commented Feb 24, 2021

Fixes brave/brave-browser#14312

This reverts commit 8dc5ce7.

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@bsclifton bsclifton added the CI/skip Do not run CI builds (except noplatform) label Feb 24, 2021
@bsclifton bsclifton added this to the 1.23.x - Nightly milestone Feb 24, 2021
@bsclifton bsclifton self-assigned this Feb 24, 2021
@bsclifton bsclifton merged commit d852513 into master Feb 24, 2021
@bsclifton bsclifton deleted the bsc-revert-file-loader-v6 branch February 24, 2021 07:48
bsclifton added a commit that referenced this pull request Feb 24, 2021
Revert "Update dependency file-loader to v6 (#7967)"
@bsclifton
Copy link
Member Author

Manually uplifted to 1.22.x with ad57711

kylehickinson pushed a commit that referenced this pull request Jan 4, 2024
Add download delegate to handle PassKit blobs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip Do not run CI builds (except noplatform)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Private, Tor, Guest windows are missing image
1 participant