Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove chrome-installer-util-google_update_constants.cc.patch #14339

Closed
mariospr opened this issue Feb 24, 2021 · 0 comments · Fixed by brave/brave-core#8062
Closed

Remove chrome-installer-util-google_update_constants.cc.patch #14339

mariospr opened this issue Feb 24, 2021 · 0 comments · Fixed by brave/brave-core#8062
Assignees
@mariospr
Labels
dev-concern OS/Desktop OS/Windows QA/No release-notes/exclude
Milestone
1.23.x - Release

Comments

@mariospr
Copy link
Contributor

mariospr commented Feb 24, 2021 •
edited
Loading

Description

This patch could be removed in favour of chromium_src overrides to redefine the values for the constants we're interested in.

Brave version (brave://version info)

Brave 1.23.1 (Chromium 89.0.4389.58)

Miscellaneous Information:

This removal references a patch initially introduced with brave/brave-core#2342
@mariospr mariospr added this to the 1.23.x - Nightly milestone Feb 24, 2021
@mariospr mariospr self-assigned this Feb 24, 2021
@mariospr mariospr mentioned this issue Feb 24, 2021
Merged
24 tasks
mariospr added a commit to brave/brave-core that referenced this issue Feb 24, 2021
@mariospr
Remove chrome-installer-util-google_update_constants.cc.patch
7d5069f 
This patch can be removed in favour of chromium_src overrides to
redefine the values for the constants we're interested in.

Resolves brave/brave-browser#14339
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mariospr mariospr

Labels
dev-concern OS/Desktop OS/Windows QA/No release-notes/exclude
Projects
None yet
Milestone
1.23.x - Release
Development

Successfully merging a pull request may close this issue.

Remove chrome-installer-util-google_update_constants.cc.patch brave/brave-core
1 participant
@mariospr