Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove chrome-installer-util-google_update_constants.cc.patch #8062

Merged
merged 1 commit into from
Feb 25, 2021

Conversation

mariospr
Copy link
Contributor

This patch can be removed in favour of chromium_src overrides to
redefine the values for the constants we're interested in.

Resolves brave/brave-browser#14339

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

N/A (it relates to #2342 but there's no test plan there)

@mariospr mariospr added this to the 1.23.x - Nightly milestone Feb 24, 2021
@mariospr mariospr requested a review from a team as a code owner February 24, 2021 12:19
@mariospr mariospr self-assigned this Feb 24, 2021
This patch can be removed in favour of chromium_src overrides to
redefine the values for the constants we're interested in.

Resolves brave/brave-browser#14339
@mariospr
Copy link
Contributor Author

All the relevant bots have passed already(*) so moving this to the review process:

Thanks!

(*) The failure on the post-init bot is unrelated (being currently worked on separately)

Copy link
Collaborator

@mkarolin mkarolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

Copy link
Member

@simonhong simonhong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mariospr mariospr merged commit a53dd23 into master Feb 25, 2021
@mariospr mariospr deleted the issues/14339 branch February 25, 2021 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove chrome-installer-util-google_update_constants.cc.patch
3 participants