Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove / Disable "Make a Call From" Chromium dialog #14601

Closed
pes10k opened this issue Mar 9, 2021 · 1 comment · Fixed by brave/brave-core#8454
Closed

Remove / Disable "Make a Call From" Chromium dialog #14601

pes10k opened this issue Mar 9, 2021 · 1 comment · Fixed by brave/brave-core#8454
Assignees
@AlexeyBarabash
Labels
branding OS/Desktop priority/P4 Planned work. We expect to get to it "soon". privacy/chromium-redqueen Work to remove or improve privacy-harming "features" added in Chromium. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Yes release-notes/include
Milestone
1.25.x - Release

Comments

@pes10k
Copy link
Contributor

pes10k commented Mar 9, 2021

When you click on a phone number, Chromium now asks if you'd like to use "Brave Sync" to call from your android device. This text / messaging doesn't make sense in Brave; we don't include this "call from" feature in Brave Sync. This issue is to remove the dialog / feature for the time being

screen_shot_2021-03-08_at_4 33 26_pm
@pes10k pes10k added branding privacy/chromium-redqueen Work to remove or improve privacy-harming "features" added in Chromium. OS/Desktop labels Mar 9, 2021
@rebron rebron added the priority/P4 Planned work. We expect to get to it "soon". label Mar 15, 2021
@AlexeyBarabash AlexeyBarabash self-assigned this Apr 6, 2021
@AlexeyBarabash AlexeyBarabash mentioned this issue Apr 6, 2021
Merged
24 tasks
AlexeyBarabash added a commit to brave/brave-core that referenced this issue Apr 7, 2021
@AlexeyBarabash
Disable Make a Call From option
8a69445 
fixes brave/brave-browser#14601
fixes brave/brave-browser#11526
@AlexeyBarabash AlexeyBarabash added this to the 1.25.x - Nightly milestone Apr 12, 2021
@rebron rebron mentioned this issue Apr 13, 2021
Closed
@btlechowski
Copy link

btlechowski commented Apr 15, 2021 •
edited by GeetaSarvadnya
Loading

Verification passed on

Brave 1.25.18 Chromium: 90.0.4430.72 (Official Build) nightly (64-bit)
Revision b6172ef8d07ef486489a4b11b66b2eaeed50d132-refs/branch-heads/4430@{#1233}
OS Ubuntu 18.04 LTS

Verified test plan from brave/brave-core#8454

image

Verification passed on

Brave 1.25.22 Chromium: 90.0.4430.72 (Official Build) nightly (x86_64)
Revision b6172ef8d07ef486489a4b11b66b2eaeed50d132-refs/branch-heads/4430@{#1233}
OS macOS Version 11.2.3 (Build 20D91)

Verified test plan from brave/brave-core#8454

example example
Screen Shot 2021-04-16 at 12 50 02 PM Screen Shot 2021-04-16 at 12 50 09 PM

Verification passed on

Brave | 1.25.22 Chromium: 90.0.4430.72 (Official Build) nightly (64-bit)
-- | --
Revision | b6172ef8d07ef486489a4b11b66b2eaeed50d132-refs/branch-heads/4430@{#1233}
OS | Windows 10 OS Version 2004 (Build 19041.928)

@LaurenWags LaurenWags mentioned this issue May 26, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AlexeyBarabash AlexeyBarabash

Labels
branding OS/Desktop priority/P4 Planned work. We expect to get to it "soon". privacy/chromium-redqueen Work to remove or improve privacy-harming "features" added in Chromium. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Yes release-notes/include
Projects
None yet
Milestone
1.25.x - Release
Development

Successfully merging a pull request may close this issue.

Disable Make a Call From option brave/brave-core
6 participants
@pes10k @stephendonner @rebron @AlexeyBarabash @btlechowski @GeetaSarvadnya