Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fingerprinting 2.0: User Agent - follow up to #12638 #14740

Closed
pes10k opened this issue Mar 15, 2021 · 3 comments · Fixed by brave/brave-core#8320
Closed

Fingerprinting 2.0: User Agent - follow up to #12638 #14740

pes10k opened this issue Mar 15, 2021 · 3 comments · Fixed by brave/brave-core#8320
Assignees
@pilgrim-brave
Labels
feature/shields/fingerprint The fingerprinting (aka: "device recognition") protection provided in Shields OS/Android Fixes related to Android browser functionality privacy-pod Feature work for the Privacy & Web Compatibility pod QA Pass - Android ARM QA Pass - Android Tab QA/Test-All-Device-Types QA/Yes regression release-notes/exclude
Milestone
1.23.x - Release #2

Comments

@pes10k
Copy link
Contributor

pes10k commented Mar 15, 2021

We have some reports of the Android device info reappearing in the Android UA, w/ or w/o farbling.

This issue is to i) correct the regression if it can be reproduced, and ii) add / correct the tests so we can catch any future possible regressions faster in the future

image
(see "pixel 4a (5G)" in the UA below
@pes10k pes10k added feature/shields/fingerprint The fingerprinting (aka: "device recognition") protection provided in Shields regression OS/Android Fixes related to Android browser functionality privacy-pod Feature work for the Privacy & Web Compatibility pod labels Mar 15, 2021
@tjm00 tjm00 mentioned this issue Mar 21, 2021
Closed
@pilgrim-brave pilgrim-brave mentioned this issue Mar 22, 2021
Merged
24 tasks
@srirambv srirambv mentioned this issue Apr 12, 2021
Closed
@srirambv
Copy link
Contributor

srirambv commented Apr 12, 2021 •
edited
Loading

+1 from @ristein and @svilupposoftware via #15103

@srirambv srirambv mentioned this issue Apr 16, 2021
Closed
@srirambv
Copy link
Contributor

+1 from @Brave-Matt via #15322.

@pes10k @pilgrim-brave issue is missing milestone. Since its already landed on nightly need to decide which milestone this will go in.

cc: @rebron @bbondy

@kjozwiak kjozwiak mentioned this issue Apr 22, 2021
Closed
@kjozwiak kjozwiak added this to the 1.24.x - Beta milestone Apr 22, 2021
This was referenced Apr 22, 2021
Merged
Merged
@srirambv
Copy link
Contributor

Verification passed on the following devices running 1.23.73 x64 build

  • Verified steps from issue description
OnePlus 6T (Android 10) Samsung Tab A (Android 10)

@kjozwiak kjozwiak mentioned this issue Apr 23, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pilgrim-brave pilgrim-brave

Labels
feature/shields/fingerprint The fingerprinting (aka: "device recognition") protection provided in Shields OS/Android Fixes related to Android browser functionality privacy-pod Feature work for the Privacy & Web Compatibility pod QA Pass - Android ARM QA Pass - Android Tab QA/Test-All-Device-Types QA/Yes regression release-notes/exclude
Projects
None yet
Milestone
1.23.x - Release #2
Development

Successfully merging a pull request may close this issue.

Fix farbled user agent on mobile brave/brave-core
4 participants
@pes10k @kjozwiak @srirambv @pilgrim-brave