Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove HTTP User-Agent farbling #15372

Closed
pilgrim-brave opened this issue Apr 19, 2021 · 2 comments · Fixed by brave/brave-core#8562
Closed

Remove HTTP User-Agent farbling #15372

pilgrim-brave opened this issue Apr 19, 2021 · 2 comments · Fixed by brave/brave-core#8562
Assignees
Labels
OS/Android Fixes related to Android browser functionality OS/Desktop QA/No release-notes/include

Comments

@pilgrim-brave
Copy link

Brave's initial implementation of farbling the User-Agent string sent with HTTP requests has proven to be difficult to maintain (subtle changes upstream have lead to regressions that are difficult to debug). With C90's effective freezing of the Mac OS X version string (to 10.5.7, for compatibility reasons), our implementation will provide ever smaller privacy benefits over time.

@stephendonner
Copy link

@pilgrim-brave would you please drop a test plan we can follow over in brave/brave-core#8562? Thanks! /cc @pes10k since I see you were also working on abating this with Cloudflare.

Also looping in @brave/legacy_qa

@kjozwiak
Copy link
Member

Talked to @pes10k earlier via the uplift thread. Labeling this as QA/No as the checks will be done via #15039, #15322 & #14740. @pes10k let me know if that sounds right or if there's anything else that we need to check for this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OS/Android Fixes related to Android browser functionality OS/Desktop QA/No release-notes/include
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants